Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-17 Thread Amit Kapila
On Fri, Mar 17, 2017 at 12:30 PM, Ashutosh Sharma wrote: > On Fri, Mar 17, 2017 at 9:03 AM, Amit Kapila wrote: >> On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma >> wrote: >>> Hi, >>> >>> Attached is the patch that allows WAL consistency tool to mask >>> 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-17 Thread Ashutosh Sharma
On Fri, Mar 17, 2017 at 9:03 AM, Amit Kapila wrote: > On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma > wrote: >> Hi, >> >> Attached is the patch that allows WAL consistency tool to mask >> 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a >> part of 'Microvacuum support for

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-16 Thread Amit Kapila
On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma wrote: > Hi, > > Attached is the patch that allows WAL consistency tool to mask > 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a > part of 'Microvacuum support for Hash index' patch . I have already > tested it using Kuntal's

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-16 Thread Ashutosh Sharma
Hi, Attached is the patch that allows WAL consistency tool to mask 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a part of 'Microvacuum support for Hash index' patch . I have already tested it using Kuntal's WAL consistency tool and it works fine. -- With Regards, Ashutosh S

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-14 Thread Kuntal Ghosh
On Wed, Mar 15, 2017 at 12:32 AM, Robert Haas wrote: > On Mon, Mar 13, 2017 at 10:36 AM, Ashutosh Sharma > wrote: >> Couple of review comments,, >> >> You may also need to update the documentation as now we are also going >> to support wal consistency check for hash index. The current >> documen

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-14 Thread Robert Haas
On Mon, Mar 13, 2017 at 10:36 AM, Ashutosh Sharma wrote: > Couple of review comments,, > > You may also need to update the documentation as now we are also going > to support wal consistency check for hash index. The current > documentation does not include hash index. > > +only records or

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-13 Thread Ashutosh Sharma
Couple of review comments,, You may also need to update the documentation as now we are also going to support wal consistency check for hash index. The current documentation does not include hash index. +only records originating from those resource managers. Currently, +the suppo

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-08 Thread Kuntal Ghosh
On Fri, Mar 3, 2017 at 9:44 AM, Amit Kapila wrote: > On Tue, Feb 28, 2017 at 11:06 AM, Kuntal Ghosh > wrote: >> Hello everyone, >> >> I've attached a patch which implements WAL consistency checking for >> hash indexes. This feature is going to be useful for developing and >> testing of WAL loggin

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-04 Thread Amit Kapila
On Sat, Mar 4, 2017 at 2:29 PM, Robert Haas wrote: > On Fri, Mar 3, 2017 at 9:44 AM, Amit Kapila wrote: >> On Tue, Feb 28, 2017 at 11:06 AM, Kuntal Ghosh >> wrote: >>> Hello everyone, >>> >>> I've attached a patch which implements WAL consistency checking for >>> hash indexes. This feature is go

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-04 Thread Robert Haas
On Fri, Mar 3, 2017 at 9:44 AM, Amit Kapila wrote: > On Tue, Feb 28, 2017 at 11:06 AM, Kuntal Ghosh > wrote: >> Hello everyone, >> >> I've attached a patch which implements WAL consistency checking for >> hash indexes. This feature is going to be useful for developing and >> testing of WAL loggin

Re: [HACKERS] WAL Consistency checking for hash indexes

2017-03-02 Thread Amit Kapila
On Tue, Feb 28, 2017 at 11:06 AM, Kuntal Ghosh wrote: > Hello everyone, > > I've attached a patch which implements WAL consistency checking for > hash indexes. This feature is going to be useful for developing and > testing of WAL logging for hash index. > I think it is better if you base your pa