Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-14 Thread Robert Haas
On Fri, Dec 14, 2012 at 3:46 PM, Dimitri Fontaine wrote: > Robert Haas writes: >>> Robert, does that ring a bell to you? I'm going to crawl the archives >>> tomorrow if not… >> >> Yeah, I'm pretty sure you can't set event triggers of any kind on >> event triggers. You proposed to allow some stuf

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-14 Thread Dimitri Fontaine
Robert Haas writes: >> Robert, does that ring a bell to you? I'm going to crawl the archives >> tomorrow if not… > > Yeah, I'm pretty sure you can't set event triggers of any kind on > event triggers. You proposed to allow some stuff that would affect > "every command", but I yelled and screamed

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-14 Thread Robert Haas
On Fri, Dec 14, 2012 at 2:00 PM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Dec 13, 2012 at 6:25 PM, Tom Lane wrote: >>> I suspect there are still ways to shoot yourself in the foot with a >>> broken event trigger, but it's not quite as trivial as I thought. > >> I'm smart enough not to do

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-14 Thread Tom Lane
Robert Haas writes: > On Thu, Dec 13, 2012 at 6:25 PM, Tom Lane wrote: >> I suspect there are still ways to shoot yourself in the foot with a >> broken event trigger, but it's not quite as trivial as I thought. > I'm smart enough not to doubt you, but I'd sure appreciate a hint as > to what you'

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-14 Thread Robert Haas
On Thu, Dec 13, 2012 at 6:25 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Dec 12, 2012 at 3:51 PM, Dimitri Fontaine >> wrote: >>> Robert, does that ring a bell to you? I'm going to crawl the archives >>> tomorrow if not… > >> Yeah, I'm pretty sure you can't set event triggers of any kind

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-13 Thread Tom Lane
Robert Haas writes: > On Wed, Dec 12, 2012 at 3:51 PM, Dimitri Fontaine > wrote: >> Robert, does that ring a bell to you? I'm going to crawl the archives >> tomorrow if not… > Yeah, I'm pretty sure you can't set event triggers of any kind on > event triggers. You proposed to allow some stuff th

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-13 Thread Robert Haas
On Wed, Dec 12, 2012 at 3:51 PM, Dimitri Fontaine wrote: > Tom Lane writes: >>> Maybe we could just append to it how to remove such an event trigger, >>> which is easy to do because you can't target an event trigger related >>> command with event triggers, so the following is not disabled: >>>

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-12 Thread Dimitri Fontaine
Tom Lane writes: >> Maybe we could just append to it how to remove such an event trigger, >> which is easy to do because you can't target an event trigger related >> command with event triggers, so the following is not disabled: >> DROP EVENT TRIGGER abort_ddl; > > Oh really? The explanation

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-12 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> BTW, is the example in the CREATE EVENT TRIGGER ref page meant as an >> IQ test for unwary readers? > Maybe we could just append to it how to remove such an event trigger, > which is easy to do because you can't target an event trigger related > com

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-12 Thread Dimitri Fontaine
Tom Lane writes: > Yeah, I had forgotten about that loose end, but we definitely need > something of the sort. Committed with additional documentation. > (I put something in the CREATE EVENT TRIGGER ref page, but do we > need anything about it in chapter 37?) Thanks! I guess we could add a note

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-11 Thread Tom Lane
Dimitri Fontaine writes: > I don't remember that we fixed that case, I did attach a patch in the > previous email, what do you think? Yeah, I had forgotten about that loose end, but we definitely need something of the sort. Committed with additional documentation. (I put something in the CREATE

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-12-11 Thread Dimitri Fontaine
Hi, I don't remember that we fixed that case, I did attach a patch in the previous email, what do you think? Dimitri Fontaine writes: > Tom Lane writes: >> Or maybe we should disable event triggers altogether in standalone mode? > > Would something as simple as the attached work for doing that?

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-08-31 Thread Dimitri Fontaine
Tom Lane writes: > Or maybe we should disable event triggers altogether in standalone mode? Would something as simple as the attached work for doing that? (passes make check and I did verify manually that postmaster --single is happy with it and skipping Event Triggers). Regards, -- Dimitri Fon

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-08-30 Thread Dimitri Fontaine
Tom Lane writes: > I find $SUBJECT fairly scary, because systable_beginscan_ordered() is > dependent on having a working, non-corrupt index. If you are trying > to run the backend with ignore_system_indexes so that you can rebuild > corrupt indexes, uses of systable_beginscan_ordered() represent

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-08-28 Thread Robert Haas
On Tue, Aug 28, 2012 at 12:47 PM, Andres Freund wrote: > On Tuesday, August 28, 2012 06:39:50 PM Tom Lane wrote: >> Or maybe we should disable event triggers altogether in standalone mode? >> I can think of plenty of ways that a broken event trigger could cause >> enough havoc that you'd wish ther

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-08-28 Thread Andres Freund
On Tuesday, August 28, 2012 06:39:50 PM Tom Lane wrote: > Or maybe we should disable event triggers altogether in standalone mode? > I can think of plenty of ways that a broken event trigger could cause > enough havoc that you'd wish there was a way to suppress it, at least > for long enough to dro