Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 20:44 -0500, Tom Lane wrote: > It does, although I find that the warnings are of little use since > people tend not to read every line of configure's output. AFAICS no such warning is emitted. Perhaps you are thinking of the warnings about using the wrong version of bison, or

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Why not just disable warnings for just the flex-generated files? Because it's a pain in the neck to do so; it'll require klugery in half a dozen different Makefiles. (I don't see any easy way to make the change apply only to the flex files, and not to the

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Kevin HaleBoyes <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> That's because you're using a badly broken flex: > % flex --version > flex 2.5.31 > That is, configure could check the version of various tools, like > flex, and warn if appropriate. It does, although I find that the warnings are of

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Kevin HaleBoyes
Tom Lane wrote: That's because you're using a badly broken flex: % flex --version flex 2.5.31 I know very little (enough to get by) about the configuration phase when building postgresql but couldn't this be checked for? That is, configure could check the version of various tools, like flex, and

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 20:22 -0500, Tom Lane wrote: > That's because you're using a badly broken flex Sure, but my point is just that different versions of flex, in general, will provoke different compiler warnings. I don't see that it is a net win to disable a flag across the _whole_ source tree j

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I think this is the better course. At least here, flex-generated files > produce warnings even without -Wold-style-definition: That's because you're using a badly broken flex: > % flex --version > flex 2.5.31 I'd recommend reverting to 2.5.4. IIRC we ha

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 14:59 -0500, Tom Lane wrote: > > Would it not be possible to suppress the warnings just for the > > flex-generated code? > > IMHO it's not worth the trouble. I think this is the better course. At least here, flex-generated files produce warnings even without -Wold-style-def

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Alvaro Herrera
On Wed, Nov 17, 2004 at 01:50:00PM -0500, Tom Lane wrote: > I'd like to propose removing -Wold-style-definition from the default gcc > flags. It is cluttering my make logs with warnings that can't be got > rid of because they are about code generated by flex. Oh, so that's what all the noise I se

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'd like to propose removing -Wold-style-definition from the default gcc >> flags. It is cluttering my make logs with warnings that can't be got >> rid of because they are about code generated by flex. > Would it not be possible to s

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Andrew Dunstan
Tom Lane wrote: I'd like to propose removing -Wold-style-definition from the default gcc flags. It is cluttering my make logs with warnings that can't be got rid of because they are about code generated by flex. Would it not be possible to suppress the warnings just for the flex-generated cod