Re: [HACKERS] Testing the return value of fclose() in the backend

2003-06-07 Thread Bruce Momjian
Added to TODO: * Add checks for fclose() failure --- Gavin Sherry wrote: > On Fri, 30 May 2003, Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Gavin Sherry wrote: > > >> There are various pl

Re: [HACKERS] Testing the return value of fclose() in the backend

2003-05-31 Thread Gavin Sherry
On Fri, 30 May 2003, Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Gavin Sherry wrote: > >> There are various places in the backend, such as FreeFile(), where the > >> return value of fclose() is not tested. > > > We are not checking fclose, probably because fclose failures are

Re: [HACKERS] Testing the return value of fclose() in the backend

2003-05-31 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Gavin Sherry wrote: >> There are various places in the backend, such as FreeFile(), where the >> return value of fclose() is not tested. > We are not checking fclose, probably because fclose failures are quite > rare. Should we be concerned? Probably.

Re: [HACKERS] Testing the return value of fclose() in the backend

2003-05-31 Thread Gavin Sherry
On Fri, 30 May 2003, Bruce Momjian wrote: > Gavin Sherry wrote: > > Hi all, > > > > There are various places in the backend, such as FreeFile(), where the > > return value of fclose() is not tested. Whilst we would often notice any > > problems with writing to data files due to testing on fsync()

Re: [HACKERS] Testing the return value of fclose() in the backend

2003-05-31 Thread Bruce Momjian
Gavin Sherry wrote: > Hi all, > > There are various places in the backend, such as FreeFile(), where the > return value of fclose() is not tested. Whilst we would often notice any > problems with writing to data files due to testing on fsync(), it could > affect things like COPY ... TO, CreateOpts