Re: [HACKERS] Testing the other tsearch dictionaries

2007-08-28 Thread Heikki Linnakangas
Andrew Dunstan wrote: > Tom Lane wrote: >> >> No, we have the ability to run a contrib module that's already been >> installed. pg_regress cannot assume it has write privileges on >> $SHAREDIR --- consider the "make installcheck" case. > > How big are these files? If small, is there a reason we c

Re: [HACKERS] Testing the other tsearch dictionaries

2007-08-28 Thread Andrew Dunstan
Tom Lane wrote: No, we have the ability to run a contrib module that's already been installed. pg_regress cannot assume it has write privileges on $SHAREDIR --- consider the "make installcheck" case. How big are these files? If small, is there a reason we can't

Re: [HACKERS] Testing the other tsearch dictionaries

2007-08-28 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The difficulty in testing these is that they require configuration >> files, which the regression tests really can't install. (If the >> configuration were all inside the database it wouldn't be such a >> problem, but that's a l

Re: [HACKERS] Testing the other tsearch dictionaries

2007-08-28 Thread Heikki Linnakangas
Tom Lane wrote: > I was a bit unhappy to realize just now that the patch Heikki sent in, > and I reviewed and applied, actually broke dict_synonym. (Modifying a > string tends to modify the result of strlen() ...) While we can't > cover *everything* in the regression tests, it now seems like a ba