Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-02 Thread Magnus Hagander
On Sun, Feb 1, 2015 at 9:14 PM, Noah Misch wrote: > On Sun, Feb 01, 2015 at 10:50:24AM -0500, Tom Lane wrote: > > Peter Eisentraut writes: > > > At least writing `pg_config --sysconfdir` indicates that it's in an > > > installation-specific location, whereas hardcoding /etc will create > > > con

Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-01 Thread Noah Misch
On Sun, Feb 01, 2015 at 10:50:24AM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > At least writing `pg_config --sysconfdir` indicates that it's in an > > installation-specific location, whereas hardcoding /etc will create > > confusion when it's not actually there. (Incidentally, we use >

Re: [HACKERS] Small doc patch about pg_service.conf

2015-02-01 Thread Tom Lane
Peter Eisentraut writes: > At least writing `pg_config --sysconfdir` indicates that it's in an > installation-specific location, whereas hardcoding /etc will create > confusion when it's not actually there. (Incidentally, we use > /usr/local/pgsql/etc elsewhere in the documentation as a sample lo

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-31 Thread Peter Eisentraut
On 1/3/15 7:56 PM, Tom Lane wrote: > Noah Misch writes: >> On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: >>> The directory libpq consults is `pg_config --sysconfdir` > >> I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which >> adjusts >> to post-installation moves

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 07:56:06PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: > >> The directory libpq consults is `pg_config --sysconfdir` > > > I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which > > adjusts >

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
Noah Misch writes: > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: >> The directory libpq consults is `pg_config --sysconfdir` > I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts > to post-installation moves of the installation tree. parseServiceInfo()

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: > The directory libpq consults is `pg_config --sysconfdir` I was wrong there. `pg_config --sysconfig` uses get_etc_path(), which adjusts to post-installation moves of the installation tree. parseServiceInfo() uses the build-time SYSCONF

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
Magnus Hagander writes: > On Sat, Jan 3, 2015 at 10:52 PM, Andrew Dunstan wrote: >> On 01/03/2015 04:41 PM, Magnus Hagander wrote: >>> Yeah. But let's make sure we include "usually /etc" or something like >>> that. >> But it's not usually /etc. Certainly it's not in the PGDG RPM builds >> unless

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Sat, Jan 3, 2015 at 10:52 PM, Andrew Dunstan wrote: > > On 01/03/2015 04:41 PM, Magnus Hagander wrote: > >> >> >> We could do worse than to say it's in the directory printed by >> "pg_config --sysconfdir". >> >> >> Yeah. But let's make sure we include "usually /etc" or something like >

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Andrew Dunstan
On 01/03/2015 04:41 PM, Magnus Hagander wrote: We could do worse than to say it's in the directory printed by "pg_config --sysconfdir". Yeah. But let's make sure we include "usually /etc" or something like that. But it's not usually /etc. Certainly it's not in the PGDG RPM bui

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Sat, Jan 3, 2015 at 9:03 PM, Tom Lane wrote: > David Fetter writes: > > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: > >> The old and the new documentation are both wrong. The directory libpq > >> consults is `pg_config --sysconfdir`, which is packager-selected but > rarely >

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 03:03:45PM -0500, Tom Lane wrote: > David Fetter writes: > > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: > >> The old and the new documentation are both wrong. The directory libpq > >> consults is `pg_config --sysconfdir`, which is packager-selected but rar

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Tom Lane
David Fetter writes: > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: >> The old and the new documentation are both wrong. The directory libpq >> consults is `pg_config --sysconfdir`, which is packager-selected but rarely >> matches /etc itself. parseServiceInfo() has the code in qu

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote: > On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: > > On Wed, Dec 31, 2014 at 3:24 PM, David Fetter wrote: > > > There was a slash missing, which I've added. Where is the default > > > directory on Windows, or is there o

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Noah Misch
On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: > On Wed, Dec 31, 2014 at 3:24 PM, David Fetter wrote: > > There was a slash missing, which I've added. Where is the default > > directory on Windows, or is there one? > > > > Applied, thanks. The old and the new documentation are

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread David Fetter
On Sat, Jan 03, 2015 at 01:22:02PM +0100, Magnus Hagander wrote: > On Wed, Dec 31, 2014 at 3:24 PM, David Fetter wrote: > > > Folks, > > > > There was a slash missing, which I've added. Where is the default > > directory on Windows, or is there one? > > > > Applied, thanks. Thank you. > And -

Re: [HACKERS] Small doc patch about pg_service.conf

2015-01-03 Thread Magnus Hagander
On Wed, Dec 31, 2014 at 3:24 PM, David Fetter wrote: > Folks, > > There was a slash missing, which I've added. Where is the default > directory on Windows, or is there one? > Applied, thanks. And - from a quick check, it looks like it's actually using "/etc" on Windows as well. Which is somewh