Re: [HACKERS] SSI update

2010-11-15 Thread Kevin Grittner
Alvaro Herrera wrote: > I remind you, though, that the most painful point that caused the > commitfest process to come into existance was the HOT patch, which > was very large and intrusive and didn't get any review until very > late in the cycle. So getting some review earlier than at the > la

Re: [HACKERS] SSI update

2010-11-15 Thread Robert Haas
On Mon, Nov 15, 2010 at 10:56 AM, Kevin Grittner wrote: > Greg Smith wrote: > >> I could use a brief reminder of how this bit fits into the >> "serializable lock consistency" patch that's already sitting into >> the CF queue as "Ready for Committer" though. > > [explanation] The short version is

Re: [HACKERS] SSI update

2010-11-15 Thread Kevin Grittner
Greg Smith wrote: > I could use a brief reminder of how this bit fits into the > "serializable lock consistency" patch that's already sitting into > the CF queue as "Ready for Committer" though. Florian's patch prevents an "integrity inversion" that PostgreSQL has had for ages, where attemptin

Re: [HACKERS] SSI update

2010-11-15 Thread Alvaro Herrera
Excerpts from Greg Smith's message of lun nov 15 12:32:25 -0300 2010: > I could use a brief reminder of how this bit fits into the "serializable > lock consistency" patch that's already sitting into the CF queue as > "Ready for Committer" though. I remind you, though, that the most painful poin

Re: [HACKERS] SSI update

2010-11-15 Thread Greg Smith
Kevin Grittner wrote: That went in an hour and a half before the CF deadline, but I just didn't feel right putting it into the CF in that shape. Then keep on working on it and we can revisit its state when you're happy with it. The purpose of the CommitFest cut-off is not to block work on lo

Re: [HACKERS] SSI update

2010-11-15 Thread Kevin Grittner
David Fetter wrote: > That it's not ready for commit this minute does not mean that it > shouldn't be in the CF this month. Delaying the first review of > the patch until the next CF pretty much ensures that we'll miss > 9.1 with it, so please add to the current CF :) Well, I had a version wh

Re: [HACKERS] SSI update

2010-11-14 Thread David Fetter
That it's not ready for commit this minute does not mean that it shouldn't be in the CF this month. Delaying the first review of the patch until the next CF pretty much ensures that we'll miss 9.1 with it, so please add to the current CF :) Cheers, David. On Sat, Nov 13, 2010 at 02:15:40PM -0600,