Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-05 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 3:15 PM, Albe Laurenz wrote: > Magnus Hagander wrote: On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote: > I think that the column name is ok as it is, even if it > is a bit long - I cannot come up with a more succinct > idea. Perhaps "n_changed_si

Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-01 Thread Albe Laurenz
Magnus Hagander wrote: >>> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz >>> wrote: I think that the column name is ok as it is, even if it is a bit long - I cannot come up with a more succinct idea. Perhaps "n_changed_since_analyze" could be shortened to "n_mod_since_analyze

Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-01 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 2:48 PM, Albe Laurenz wrote: > Magnus Hagander wrote: >> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz >> wrote: >>> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz >>> >>> The patch applies cleanly (with the exception of catversion.h of course), >>> comp

Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-01 Thread Albe Laurenz
Magnus Hagander wrote: > On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote: >> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz >> >> The patch applies cleanly (with the exception of catversion.h of course), >> compiles without warnings and passes the regression tests. >> >> It

Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-01 Thread Magnus Hagander
On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote: > This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz > > The patch applies cleanly (with the exception of catversion.h of course), > compiles without warnings and passes the regression tests. > > It contains enough documentation,