Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-26 Thread Bruce Momjian
Patch applied from Neil. --- Marko Kreen wrote: > On 4/23/07, Neil Conway <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote: > > > Attached patch does following conversions: > > > > ISTM it

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-26 Thread Neil Conway
On Tue, 2007-04-24 at 18:04 +0300, Marko Kreen wrote: > Attached patch addresses all 3 comments. As it will be > top-level command, I put code into commands/discard.c Applied with some minor tweaks -- thanks for the patch. I didn't bother moving the regression tests out of guc.sql, although they

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-24 Thread Marko Kreen
On 4/23/07, Neil Conway <[EMAIL PROTECTED]> wrote: On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote: > Attached patch does following conversions: ISTM it would be cleaner to use an enum to identify the different variants of the DISCARD command, rather than a character string. Is guc.c still

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-23 Thread Neil Conway
On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote: > Attached patch does following conversions: ISTM it would be cleaner to use an enum to identify the different variants of the DISCARD command, rather than a character string. Is guc.c still the logical place for the implementation of DISCARD?

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-17 Thread Florian Pflug
Tom Lane wrote: Mark Kirkwood <[EMAIL PROTECTED]> writes: Tom Lane wrote: The current documentation for RESET exhibits a certain lack of, um, intellectual cohesiveness: Synopsis RESET configuration_parameter RESET ALL RESET { PLANS | SESSION | TEMP | TEMPORARY } Maybe DISCARD for the plans

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-17 Thread Marko Kreen
On 4/17/07, Marko Kreen <[EMAIL PROTECTED]> wrote: If DISCARD is the final word, I start to prepare a patch. Attached patch does following conversions: RESET PLANS -> DISCARD PLANS RESET TEMP -> DISCARD TEMP RESET SESSION -> DISCARD ALL -- marko discard.diff.gz Description: GNU Zip compress

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-17 Thread Marko Kreen
On 4/17/07, Tom Lane <[EMAIL PROTECTED]> wrote: Florian Pflug <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >>> The current documentation for RESET exhibits a certain lack of, um, >>> intellectual cohesiveness: > What about > RESET parameter > RESET { PLANS | TEMP | TEMPORARY } > RESET ALL { PAR

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-16 Thread Tom Lane
Florian Pflug <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >>> The current documentation for RESET exhibits a certain lack of, um, >>> intellectual cohesiveness: > What about > RESET parameter > RESET { PLANS | TEMP | TEMPORARY } > RESET ALL { PARAMETERS | STATE } > RESET ALL would become an abb

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-16 Thread Florian G. Pflug
Tom Lane wrote: Mark Kirkwood <[EMAIL PROTECTED]> writes: Tom Lane wrote: The current documentation for RESET exhibits a certain lack of, um, intellectual cohesiveness: Synopsis RESET configuration_parameter RESET ALL RESET { PLANS | SESSION | TEMP | TEMPORARY } Maybe DISCARD for the plans

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-16 Thread Tom Lane
Mark Kirkwood <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The current documentation for RESET exhibits a certain lack of, um, >> intellectual cohesiveness: >> >> Synopsis >> >> RESET configuration_parameter >> RESET ALL >> RESET { PLANS | SESSION | TEMP | TEMPORARY } > Maybe DISCARD for the

Re: [HACKERS] RESET command seems pretty disjointed now

2007-04-15 Thread Mark Kirkwood
Tom Lane wrote: The current documentation for RESET exhibits a certain lack of, um, intellectual cohesiveness: Name RESET -- restore the value of a run-time parameter to the default value Synopsis RESET configuration_parameter RESET ALL RESET { PLANS | SESSION | TEMP | TEMPORARY } That one-