Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-11 Thread Magnus Hagander
On Mon, Dec 10, 2007 at 09:56:39AM +, Dave Page wrote: > Dave Page wrote: > > Tom Lane wrote: > >> Dave Page <[EMAIL PROTECTED]> writes: > >>> Gregory Stark wrote: > An alternative is leaving it in the project file but putting > something like > this in c.h: > >> > >> Put it in w

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-10 Thread Dave Page
Dave Page wrote: > Tom Lane wrote: >> Dave Page <[EMAIL PROTECTED]> writes: >>> Gregory Stark wrote: An alternative is leaving it in the project file but putting something like this in c.h: >> >> Put it in win32.h, please. c.h shouldn't get cluttered with >> platform-specific kluges

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-07 Thread Dave Page
Tom Lane wrote: Dave Page <[EMAIL PROTECTED]> writes: Gregory Stark wrote: An alternative is leaving it in the project file but putting something like this in c.h: Put it in win32.h, please. c.h shouldn't get cluttered with platform-specific kluges when there's no need for it. Is there a go

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-07 Thread Tom Lane
Dave Page <[EMAIL PROTECTED]> writes: > Gregory Stark wrote: >> An alternative is leaving it in the project file but putting something like >> this in c.h: Put it in win32.h, please. c.h shouldn't get cluttered with platform-specific kluges when there's no need for it. Is there a good reason not

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-07 Thread Dave Page
Gregory Stark wrote: "Magnus Hagander" <[EMAIL PROTECTED]> writes: I guess my advice would be to see if we can define _USE_32BIT_TIME_T in port/win32.h and make it go away that way. It'd definitely be nice if MSVC and Mingw builds weren't binary-incompatible. The attached patch defines it in

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-07 Thread Gregory Stark
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> > I guess my advice would be to see if we can define _USE_32BIT_TIME_T >> > in port/win32.h and make it go away that way. It'd definitely be nice >> > if MSVC and Mingw builds weren't binary-incompatible. >> >> The attached patch defines it in the

Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

2007-12-07 Thread Magnus Hagander
> > I guess my advice would be to see if we can define _USE_32BIT_TIME_T > > in port/win32.h and make it go away that way. It'd definitely be nice > > if MSVC and Mingw builds weren't binary-incompatible. > > The attached patch defines it in the MSVC project files along with the > other API-conf