Re: [HACKERS] Possibly a typo in expand_inherited_rtentry()

2015-04-03 Thread Tom Lane
Amit Langote writes: > Attached does: > -/* Open rel if needed; we already have required locks */ > +/* Open rel if needed; we already have acquired locks */ > Does that make sense? No, not particularly. It could be made to say "the locks we require" but I don't find anything wrong with

Re: [HACKERS] Possibly a typo in expand_inherited_rtentry()

2015-04-03 Thread Amit Langote
On 03-04-2015 PM 03:58, Amit Langote wrote: > Index childRTindex; > AppendRelInfo *appinfo; > > -/* Open rel if needed; we already have required locks */ > +/* Open rel if needed; we already have acquired locks */ > if (childOID != parentOID) > newrelation = h