On Tue, Apr 21, 2015 at 10:54 AM, Andres Freund wrote:
> On 2015-04-21 10:53:08 -0400, Robert Haas wrote:
>> On Tue, Apr 21, 2015 at 6:17 AM, Craig Ringer wrote:
>> >> I don't really like the 'pid' field for pg_replication_slots. About
>> >> naming it 'active_in' or such?
>> >
>> > It was origina
On Tue, Apr 21, 2015 at 04:54:57PM +0200, Andres Freund wrote:
> On 2015-04-21 10:53:08 -0400, Robert Haas wrote:
> > On Tue, Apr 21, 2015 at 6:17 AM, Craig Ringer wrote:
> > >> I don't really like the 'pid' field for pg_replication_slots. About
> > >> naming it 'active_in' or such?
> > >
> > > It
On 2015-04-21 10:53:08 -0400, Robert Haas wrote:
> On Tue, Apr 21, 2015 at 6:17 AM, Craig Ringer wrote:
> >> I don't really like the 'pid' field for pg_replication_slots. About
> >> naming it 'active_in' or such?
> >
> > It was originally named active_pid, but changed based on feedback from
> > ot
On Tue, Apr 21, 2015 at 6:17 AM, Craig Ringer wrote:
>> I don't really like the 'pid' field for pg_replication_slots. About
>> naming it 'active_in' or such?
>
> It was originally named active_pid, but changed based on feedback from
> others that 'pid' would be consistent with pg_stat_activity and
On April 21, 2015 1:17:32 PM GMT+03:00, Craig Ringer
wrote:
>On 21 April 2015 at 15:19, Andres Freund wrote:
>
>> On 2015-04-07 18:41:59 +0800, Craig Ringer wrote:
>> > @@ -331,8 +331,8 @@ ReplicationSlotAcquire(const char *name)
>> > volatile ReplicationSlot *vslot = s;
>>
On 21 April 2015 at 15:19, Andres Freund wrote:
> On 2015-04-07 18:41:59 +0800, Craig Ringer wrote:
> > @@ -331,8 +331,8 @@ ReplicationSlotAcquire(const char *name)
> > volatile ReplicationSlot *vslot = s;
> >
> > SpinLockAcquire(&s->mutex);
> > -
On 2015-04-07 18:41:59 +0800, Craig Ringer wrote:
> @@ -331,8 +331,8 @@ ReplicationSlotAcquire(const char *name)
> volatile ReplicationSlot *vslot = s;
>
> SpinLockAcquire(&s->mutex);
> - active = vslot->active;
> -
Hi,
On 2015-04-07 18:41:59 +0800, Craig Ringer wrote:
> The attached patch adds a 'pid' column to pg_replication_slots, so it's
> possible to associate an active slot with the pg_stat_replication entry
> that describes the walsender using the slot.
This really should have been done that way from
