Re: [HACKERS] More pgindent bizarreness

2004-10-06 Thread Bruce Momjian
Neil Conway wrote: > On Fri, 2004-10-01 at 06:48, Bruce Momjian wrote: > > Yes, that is what I am thinking. I have worked around other bugs in the > > C code before by doing things with the shell script though this problem > > seems hard to clean up with a shell script. I found GNU indent to be >

Re: [HACKERS] More pgindent bizarreness

2004-10-06 Thread Neil Conway
On Fri, 2004-10-01 at 06:48, Bruce Momjian wrote: > Yes, that is what I am thinking. I have worked around other bugs in the > C code before by doing things with the shell script though this problem > seems hard to clean up with a shell script. I found GNU indent to be > even harder to fix. Have

Re: [HACKERS] More pgindent bizarreness

2004-09-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Or do you mean here? > > Both, but the multi-line case with two different indent levels is > particularly strange. > > You're right that this particular code is new in 8.0. (Looks around...) > struct f_smgr in smgr.c is a comparable

Re: [HACKERS] More pgindent bizarreness

2004-09-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Or do you mean here? Both, but the multi-line case with two different indent levels is particularly strange. You're right that this particular code is new in 8.0. (Looks around...) struct f_smgr in smgr.c is a comparable case, and it seems to have been

Re: [HACKERS] More pgindent bizarreness

2004-09-30 Thread Bruce Momjian
Tom Lane wrote: > I noticed that pgindent is doing weird things with function pointer > declarations; see for example what it did with AnalyzeAttrFetchFunc > and compute_stats in src/include/commands/vacuum.h. I don't recall > that it was doing this before the latest run. Or do you mean here?

Re: [HACKERS] More pgindent bizarreness

2004-09-30 Thread Bruce Momjian
Tom Lane wrote: > I noticed that pgindent is doing weird things with function pointer > declarations; see for example what it did with AnalyzeAttrFetchFunc > and compute_stats in src/include/commands/vacuum.h. I don't recall > that it was doing this before the latest run. You mean here? void