On Wed, Aug 27, 2014 at 2:07 PM, Michael Paquier
wrote:
> On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao wrote:
>> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
>> wrote:
>> I think that it's better to add an include guard like
>>
>> #ifndef RECEIVELOG_H
>> #define RECEIVELOG_H
>> ...
>> #end
On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao wrote:
> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
> wrote:
> I think that it's better to add an include guard like
>
> #ifndef RECEIVELOG_H
> #define RECEIVELOG_H
> ...
> #endif
Oh indeed, that was missing as well! Please see attached.
--
Mi
On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
wrote:
> On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander wrote:
>> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote:
>>> Probably that's a good idea, but do we really need Author: tags? I
>>> know we have those in a few places, but certainly
On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander wrote:
> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote:
>> Probably that's a good idea, but do we really need Author: tags? I
>> know we have those in a few places, but certainly not everywhere, and
>> as time goes by they tend to be less ac
On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas wrote:
> On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier
> wrote:
>> As mentioned in $subject, the header files in src/bin/pg_basebackup do
>> not have a comment block at the top and do not have any copyright
>> text.
>> Any reason for that? Shouldn
On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier
wrote:
> As mentioned in $subject, the header files in src/bin/pg_basebackup do
> not have a comment block at the top and do not have any copyright
> text.
> Any reason for that? Shouldn't we have something for consistency with
> the other files li
