On 2014-11-14 00:04:52 +0200, Heikki Linnakangas wrote:
> On 11/11/2014 06:55 PM, Andres Freund wrote:
> >On 2014-11-03 21:58:51 +0200, Heikki Linnakangas wrote:
> >>PS. I find the name "ReplicationSlotOnDiskDynamicSize" confusing, as it is
> >>in fact a fixed size struct. I gather it's expected th
On 11/11/2014 06:55 PM, Andres Freund wrote:
On 2014-11-03 21:58:51 +0200, Heikki Linnakangas wrote:
PS. I find the name "ReplicationSlotOnDiskDynamicSize" confusing, as it is
in fact a fixed size struct. I gather it's expected that the size of that
part might change across versions, but by that
On 2014-11-03 21:58:51 +0200, Heikki Linnakangas wrote:
> PS. I find the name "ReplicationSlotOnDiskDynamicSize" confusing, as it is
> in fact a fixed size struct. I gather it's expected that the size of that
> part might change across versions, but by that definition nothing is
> constant.
Well,
On 10/31/2014 03:46 PM, Andres Freund wrote:
On 2014-10-27 09:30:33 -0400, Tom Lane wrote:
Andres Freund writes:
On 2014-10-27 12:51:44 +0200, Heikki Linnakangas wrote:
replication/slot.c and replication/logical/snapbuild.c use a CRC on the
physical slot and snapshot files. It uses the same a
On 2014-10-27 09:30:33 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2014-10-27 12:51:44 +0200, Heikki Linnakangas wrote:
> >> replication/slot.c and replication/logical/snapbuild.c use a CRC on the
> >> physical slot and snapshot files. It uses the same algorithm as used e.g.
> >> for the
Andres Freund writes:
> On 2014-10-27 12:51:44 +0200, Heikki Linnakangas wrote:
>> replication/slot.c and replication/logical/snapbuild.c use a CRC on the
>> physical slot and snapshot files. It uses the same algorithm as used e.g.
>> for the WAL. However, they are not doing the finalization step,
On 2014-10-27 12:51:44 +0200, Heikki Linnakangas wrote:
> replication/slot.c and replication/logical/snapbuild.c use a CRC on the
> physical slot and snapshot files. It uses the same algorithm as used e.g.
> for the WAL. However, they are not doing the finalization step, FIN_CRC32()
> on the calcul
