Re: [HACKERS] Missed bet in toaster routines

2004-01-16 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Wouldn't it be a win for heap_tuple_toast_attrs() to fall out quickly >> if the tuple contains no varlena attributes? > Why sure it would. That code is quite frequently called. I take it back --- the short-circuit test already exists, but

Re: [HACKERS] Missed bet in toaster routines

2004-01-16 Thread Jan Wieck
Tom Lane wrote: Wouldn't it be a win for heap_tuple_toast_attrs() to fall out quickly if the tuple contains no varlena attributes? I'm thinking of adding a test like /* Nothing to do if tuple contains no varlena fields */ if ((newtup && !HeapTupleAllFixed(newtup)) || (o