Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Tom Lane
Andrew Dunstan writes: > Here's a patch along those lines. Looks sane in a quick once-over. Note this needs to be back-patched. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.pos

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Andrew Dunstan
On 05/14/2017 12:04 AM, Andrew Dunstan wrote: > > On 05/13/2017 11:32 PM, Robert Haas wrote: >> On Sat, May 13, 2017 at 6:22 PM, Tom Lane wrote: >>> Or at least, that's what I surmise from the fact that buildfarm critter >>> caiman has been failing that test for the last day or so, with symptoms

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Tom Lane
Andrew Dunstan writes: > On 05/13/2017 11:32 PM, Robert Haas wrote: >> Depending on the precise details of how Data::Dumper prints things >> doesn't seem like a particularly good idea. > I'd be inclined to set $Data::Dumper::Indent to 0 which would suppress > all indentation, and adjusting the te

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Andrew Dunstan
On 05/13/2017 11:32 PM, Robert Haas wrote: > On Sat, May 13, 2017 at 6:22 PM, Tom Lane wrote: >> Or at least, that's what I surmise from the fact that buildfarm critter >> caiman has been failing that test for the last day or so, with symptoms >> indicating whitespace changes in Data::Dumper out

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Andrew Dunstan
On 05/13/2017 11:43 PM, Craig Ringer wrote: > > > On 14 May 2017 11:33, "Robert Haas" > wrote: > > On Sat, May 13, 2017 at 6:22 PM, Tom Lane > wrote: > > Or at least, that's what I surmise from the fact that buildfarm > cr

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Craig Ringer
On 14 May 2017 11:33, "Robert Haas" wrote: On Sat, May 13, 2017 at 6:22 PM, Tom Lane wrote: > Or at least, that's what I surmise from the fact that buildfarm critter > caiman has been failing that test for the last day or so, with symptoms > indicating whitespace changes in Data::Dumper output.

Re: [HACKERS] Latest Data::Dumper breaks hstore_plperl regression test

2017-05-13 Thread Robert Haas
On Sat, May 13, 2017 at 6:22 PM, Tom Lane wrote: > Or at least, that's what I surmise from the fact that buildfarm critter > caiman has been failing that test for the last day or so, with symptoms > indicating whitespace changes in Data::Dumper output. Some poking into > the Fedora repo shows tha