Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-11-21 Thread Robert Haas
On Fri, Nov 19, 2010 at 7:50 AM, Alvaro Herrera wrote: > Excerpts from Greg Smith's message of vie nov 19 01:52:34 -0300 2010: > >> I'd think that if configure takes >> longer than it has to because the system is heavily loaded, the amount >> compilation time is going to suffer from that would alw

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-11-19 Thread Alvaro Herrera
Excerpts from Greg Smith's message of vie nov 19 01:52:34 -0300 2010: > I'd think that if configure takes > longer than it has to because the system is heavily loaded, the amount > compilation time is going to suffer from that would always dwarf this > component of total build time. But if thi

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-11-18 Thread Greg Smith
Gurjeet Singh wrote: Seems like it would improve performance in general, but more so under load conditions when you actually need it. I am not sure if -depth option is supported by all incarnations of 'find'. Given the way directory writes are cached by the filesystem, I'm not sure why the lo

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 7:21 PM, Tom Lane wrote: > Alvaro Herrera writes: > > Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: > >> Currently I am seeing a performance improvement of this script by only > about > >> 500 ms; say 11.8 seconds vs. 11.3 secs. But I remember d

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: >> Currently I am seeing a performance improvement of this script by only about >> 500 ms; say 11.8 seconds vs. 11.3 secs. But I remember distinctly that >> yesterday I was able to see an improvement

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:15 AM, Robert Haas wrote: > On Mon, Sep 27, 2010 at 11:08 AM, Tom Lane wrote: >> Robert Haas writes: >>> Well, the historical set of topics varies from CommitFest to >>> CommitFest, by design.  There are some that recur pretty regularly, of >>> course, like Security, P

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:28 AM, Andrew Dunstan wrote: >>> Could this perhaps be made clearer on the page, perhaps with an example? >>> It confused me recently too. >>> >>> Can you suggest something more specific? >>> >>> Well, it could say something like: >>> >>> The Message-ID can be found in t

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of lun sep 27 11:28:33 -0400 2010: > Another way to handle this might be to extract it from an http URL if > given one. +1 for this approach -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Develo

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Alvaro Herrera
Excerpts from Gurjeet Singh's message of dom sep 26 22:15:59 -0400 2010: > Currently I am seeing a performance improvement of this script by only about > 500 ms; say 11.8 seconds vs. 11.3 secs. But I remember distinctly that > yesterday I was able to see an improvement of 11% on the same virtual >

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 11:16 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 11:15 AM, Andrew Dunstan wrote: On 09/27/2010 10:39 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for orig

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:15 AM, Andrew Dunstan wrote: > > > On 09/27/2010 10:39 AM, Robert Haas wrote: > > On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan > wrote: > > On 09/27/2010 10:11 AM, Robert Haas wrote: > > What should be the value of 'Message-ID for original patch' ? > the URL: > http

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 11:08 AM, Tom Lane wrote: > Robert Haas writes: >> Well, the historical set of topics varies from CommitFest to >> CommitFest, by design.  There are some that recur pretty regularly, of >> course, like Security, Performance, and Miscellaneous.  But not every >> CF will hav

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 10:39 AM, Robert Haas wrote: On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan wrote: On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php or the ID: a

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Robert Haas writes: > Well, the historical set of topics varies from CommitFest to > CommitFest, by design. There are some that recur pretty regularly, of > course, like Security, Performance, and Miscellaneous. But not every > CF will have a section for ECPG or Refactoring, for example. In one

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Kevin Grittner
Tom Lane wrote: > I liked the idea of pre-populating with the historical set of > topics. +1 -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:54 AM, Tom Lane wrote: > Robert Haas writes: >> Andrew's question seemed to be about the message-ID.  I agree the >> topic thing is confusing, though.  I'm wondering if it would be >> sufficient to do the following - if no topic are available, instead of >> showing the

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Tom Lane
Robert Haas writes: > Andrew's question seemed to be about the message-ID. I agree the > topic thing is confusing, though. I'm wondering if it would be > sufficient to do the following - if no topic are available, instead of > showing the form, it says something like: > No topics have been crea

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:18 AM, Gurjeet Singh wrote: > On Mon, Sep 27, 2010 at 4:15 PM, Andrew Dunstan wrote: >> >> >> On 09/27/2010 10:11 AM, Robert Haas wrote: >>> What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hacker

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:15 AM, Andrew Dunstan wrote: > > > On 09/27/2010 10:11 AM, Robert Haas wrote: >> >>> What should be the value of 'Message-ID for original patch' ? >>> the URL: >>> http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php >>> or the ID: aanlktinw0hl+jqmrtwxc9y2tq

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 4:15 PM, Andrew Dunstan wrote: > > > On 09/27/2010 10:11 AM, Robert Haas wrote: > >> >> What should be the value of 'Message-ID for original patch' ? >>> the URL: >>> http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php >>> or the ID: >>> aanlktinw0hl+jqmrtw

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Andrew Dunstan
On 09/27/2010 10:11 AM, Robert Haas wrote: What should be the value of 'Message-ID for original patch' ? the URL: http://archives.postgresql.org/pgsql-hackers/2010-09/msg01837.php or the ID: aanlktinw0hl+jqmrtwxc9y2tqhcfhfgfekxyyfygv...@mail.gmail.com The latter. Could this perhaps be mad

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Mon, Sep 27, 2010 at 10:09 AM, Gurjeet Singh wrote: > On Mon, Sep 27, 2010 at 3:02 PM, Robert Haas wrote: >> >> On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh >> wrote: >> > I have been away from Postgres development for quite a while, so would >> > appreciate if someone could tell me if suc

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Gurjeet Singh
On Mon, Sep 27, 2010 at 3:02 PM, Robert Haas wrote: > On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh > wrote: > > I have been away from Postgres development for quite a while, so would > > appreciate if someone could tell me if such a patch should be submitted > for > > commitfest (since this i

Re: [HACKERS] Improving prep_buildtree used in VPATH builds

2010-09-27 Thread Robert Haas
On Sun, Sep 26, 2010 at 10:15 PM, Gurjeet Singh wrote: > I have been away from Postgres development for quite a while, so would > appreciate if someone could tell me if such a patch should be submitted for > commitfest (since this is not actually a source patch). By all means add it to the open C