Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-13 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera writes: > > Excerpts from Jeff Davis's message of mar ago 09 16:03:26 -0400 2011: > >> I think I agree with Peter here that it's not a very good idea, and I > >> don't see a big upside. With tablespaces it seems to make a little bit > >> more sense, but I'd still l

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Jeff Davis's message of mar ago 09 16:03:26 -0400 2011: >> I think I agree with Peter here that it's not a very good idea, and I >> don't see a big upside. With tablespaces it seems to make a little bit >> more sense, but I'd still lean away from that idea.

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Alvaro Herrera
Excerpts from Jeff Davis's message of mar ago 09 16:03:26 -0400 2011: > On Tue, 2011-08-09 at 14:52 -0400, Brian Pitts wrote: > > When an ext2, ext3, or ext4 filesystem is mounted directly on the > > PGDATA directory, initdb will refuse to run because it sees the > > lost+found directory that mke2f

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Tom Lane
Brian Pitts writes: > When an ext2, ext3, or ext4 filesystem is mounted directly on the PGDATA > directory, initdb will refuse to run because it sees the > lost+found directory that mke2fs created and assumes the PGDATA directory is > already in use for something other than PostgreSQL. > Attache

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Jeff Davis
On Tue, 2011-08-09 at 14:52 -0400, Brian Pitts wrote: > Attached is a patch against master which will cause a directory that > contains only lost+found to still be treated as empty. Please add this to the September commitfest at: https://commitfest.postgresql.org/ Regards, Jeff Davis --

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Jaime Casanova
On Tue, Aug 9, 2011 at 1:52 PM, Brian Pitts wrote: > When an ext2, ext3, or ext4 filesystem is mounted directly on the PGDATA > directory, initdb will refuse to run because it sees the > lost+found directory that mke2fs created and assumes the PGDATA directory is > already in use for something o

Re: [HACKERS] Ignore lost+found when checking if a directory is empty

2011-08-09 Thread Jeff Davis
On Tue, 2011-08-09 at 14:52 -0400, Brian Pitts wrote: > When an ext2, ext3, or ext4 filesystem is mounted directly on the > PGDATA directory, initdb will refuse to run because it sees the > lost+found directory that mke2fs created and assumes the PGDATA > directory is already in use for something o