Re: [HACKERS] I think we need PRE_COMMIT events for (Sub)XactCallbacks

2013-02-15 Thread Tom Lane
Pavan Deolasee writes: > I noticed you added a pre event for commit/prepare/subcommit. That > looks good. Is there a case to add it for abort/subabort too ? I > wonder if we would want to do some cleanup on the foreign servers > before the transaction is abort-recorded on the main server. I don't

Re: [HACKERS] I think we need PRE_COMMIT events for (Sub)XactCallbacks

2013-02-14 Thread Pavan Deolasee
On Fri, Feb 15, 2013 at 5:19 AM, Tom Lane wrote: > > + CallXactCallbacks(XACT_EVENT_PRE_COMMIT); > + > /* > * The remaining actions cannot call any user-defined code, so it's safe > * to start shutting down within-transaction services. But note that most > * of this stuff co

Re: [HACKERS] I think we need PRE_COMMIT events for (Sub)XactCallbacks

2013-02-14 Thread Simon Riggs
On 14 February 2013 23:49, Tom Lane wrote: > Any objections? Makes sense to me. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y