Re: [HACKERS] GatherMerge misses to push target list

2017-11-11 Thread Amit Kapila
On Sat, Nov 11, 2017 at 5:05 PM, Robert Haas wrote: > On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia > wrote: >>> In that case, can you please mark the patch [1] as ready for committer in >>> CF app >> >> Done. > > I think this patch is mostly correct, but I think the change to > planner.c isn't

Re: [HACKERS] GatherMerge misses to push target list

2017-11-11 Thread Robert Haas
On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia wrote: >> In that case, can you please mark the patch [1] as ready for committer in >> CF app > > Done. I think this patch is mostly correct, but I think the change to planner.c isn't quite right. ordered_rel->reltarget is just a dummy target list

Re: [HACKERS] GatherMerge misses to push target list

2017-09-18 Thread Rushabh Lathia
On Mon, Sep 18, 2017 at 2:48 PM, Amit Kapila wrote: > On Mon, Sep 18, 2017 at 12:46 PM, Rushabh Lathia > wrote: > > Thanks Amit for the patch. > > > > I reviewed the code changes as well as performed more testing. Patch > > looks good to me. > > > > In that case, can you please mark the patch [1

Re: [HACKERS] GatherMerge misses to push target list

2017-09-18 Thread Amit Kapila
On Mon, Sep 18, 2017 at 12:46 PM, Rushabh Lathia wrote: > Thanks Amit for the patch. > > I reviewed the code changes as well as performed more testing. Patch > looks good to me. > In that case, can you please mark the patch [1] as ready for committer in CF app > Here is the updated patch - where

Re: [HACKERS] GatherMerge misses to push target list

2017-09-18 Thread Rushabh Lathia
Thanks Amit for the patch. I reviewed the code changes as well as performed more testing. Patch looks good to me. Here is the updated patch - where added test-case clean up. On Thu, Sep 14, 2017 at 10:02 AM, Amit Kapila wrote: > On Wed, Sep 13, 2017 at 5:30 PM, Rushabh Lathia > wrote: > > O

Re: [HACKERS] GatherMerge misses to push target list

2017-09-13 Thread Amit Kapila
On Wed, Sep 13, 2017 at 5:30 PM, Rushabh Lathia wrote: > On Wed, Sep 6, 2017 at 10:04 AM, Amit Kapila > wrote: >> > > > This seems like a good optimization. I tried to simulate the test given > in the mail, initially wasn't able to generate the exact test - as index > creation is missing in the t

Re: [HACKERS] GatherMerge misses to push target list

2017-09-13 Thread Rushabh Lathia
On Wed, Sep 6, 2017 at 10:04 AM, Amit Kapila wrote: > During my recent work on costing of parallel paths [1], I noticed that > we are missing to push target list below GatherMerge in some simple > cases like below. > > Test prepration > - > create or replace function simple_fu

Re: [HACKERS] GatherMerge misses to push target list

2017-09-11 Thread Amit Kapila
On Wed, Sep 6, 2017 at 10:04 AM, Amit Kapila wrote: > During my recent work on costing of parallel paths [1], I noticed that > we are missing to push target list below GatherMerge in some simple > cases like below. > I think this should be considered as a bug-fix for 10.0, but it doesn't block an