Re: [HACKERS] Fix bug in handling of dropped columns in pltcl triggers

2016-11-08 Thread Tom Lane
Jim Nasby writes: > On 11/4/16 4:28 PM, Tom Lane wrote: >> My proposal therefore is for SPI_fnumber to ignore (not match to) >> dropped columns, and to remove any caller-side attisdropped tests that >> thereby become redundant. > Yeah, SPI users certainly shouldn't need to worry about attisdroppe

Re: [HACKERS] Fix bug in handling of dropped columns in pltcl triggers

2016-11-08 Thread Tom Lane
Jim Nasby writes: > On 11/4/16 4:28 PM, Tom Lane wrote: >> It's possible that it'd make sense for pltcl_trigger_handler to ignore >> empty-string column names in the returned list, so that the behavior >> with stupid trigger functions would be a bit more forgiving; but that >> is more or less inde

Re: [HACKERS] Fix bug in handling of dropped columns in pltcl triggers

2016-11-07 Thread Jim Nasby
On 11/4/16 4:28 PM, Tom Lane wrote: My proposal therefore is for SPI_fnumber to ignore (not match to) dropped columns, and to remove any caller-side attisdropped tests that thereby become redundant. Yeah, SPI users certainly shouldn't need to worry about attisdropped, and exposing attnum doesn

Re: [HACKERS] Fix bug in handling of dropped columns in pltcl triggers

2016-11-04 Thread Tom Lane
Michael Paquier writes: > On Tue, Nov 1, 2016 at 4:17 AM, Jim Nasby wrote: >> While reviewing code coverage in pltcl, I uncovered a bug in trigger >> function return handling. If you returned the munged name of a dropped >> column, that would silently be ignored. It would be unusual to hit this,

Re: [HACKERS] Fix bug in handling of dropped columns in pltcl triggers

2016-11-01 Thread Michael Paquier
On Tue, Nov 1, 2016 at 4:17 AM, Jim Nasby wrote: > While reviewing code coverage in pltcl, I uncovered a bug in trigger > function return handling. If you returned the munged name of a dropped > column, that would silently be ignored. It would be unusual to hit this, > since dropped columns end up