On 01/18/2014 03:21 PM, Michael Paquier wrote:
> So, except for the regression output problem, I think that the code is
> clean so marking it as "Ready for committer" on the commit fest app.
Thank you for the review. Sorry about the regression thing. I tried to
randomize it a bit so that I would
On Thu, Jan 16, 2014 at 9:03 AM, Vik Fearing wrote:
> New patch attached, with regression tests.
Thanks for the new version, I have spent some time looking at it:
- Patch compiles without warnings.
- Done some manual testing with CREATE/ALTER TABLESPACE WITH and
checked pg_tablespace, it worked f
On 01/15/2014 03:07 AM, Michael Paquier wrote:
> I just had a quick look at this patch, no testing at all.
Thank you for looking at it.
> I am seeing that regression tests are still missing here, they should be
> added in
> src/test/regress/input/tablespace.source.
New patch attached, with re
On Wed, Jan 15, 2014 at 2:02 PM, Jim Nasby wrote:
> You know, this doesn't do much to encourage people to submit patches since
> it was just suggested that we use WITH instead of SET. :(
Sorry, you are right.
> Anyone have an easy way to see which is more prevalent? I'd be stuck with \h
> or tryi
On 1/14/14, 8:07 PM, Michael Paquier wrote:
On Wed, Jan 15, 2014 at 10:27 AM, Vik Fearing wrote:
On 12/26/2013 06:10 PM, David Fetter wrote:
On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
I was recently annoyed that I had to do
CREATE TABLESPACE x LOCATION y;
ALTER TABLESPACE x
On Wed, Jan 15, 2014 at 10:27 AM, Vik Fearing wrote:
> On 12/26/2013 06:10 PM, David Fetter wrote:
>> On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
>>> I was recently annoyed that I had to do
>>>
>>> CREATE TABLESPACE x LOCATION y;
>>> ALTER TABLESPACE x SET (random_page_cost = z);
On 12/26/2013 06:10 PM, David Fetter wrote:
> On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
>> I was recently annoyed that I had to do
>>
>> CREATE TABLESPACE x LOCATION y;
>> ALTER TABLESPACE x SET (random_page_cost = z);
>>
>> The attached patch is a quick n' dirty extension to all
