Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Takahiro Itagaki
Robert Haas wrote: > I think so. I'm not sure if it will push out the comment that is > immediately adjacent to the trailing semicolon, but I don't think it > will decrease the indent on the ones you've indented more. I think > this is close enough for now and you should go ahead and commit it

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 3:31 AM, Takahiro Itagaki wrote: > > Tom Lane wrote: > >> > I don't necessarily know what the right thing to do with the new ones >> > is, but I am pretty sure that pg_indent will revert any changes you >> > make to the existing ones. >> >> That it will.  The proposed chang

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Takahiro Itagaki
Tom Lane wrote: > > I don't necessarily know what the right thing to do with the new ones > > is, but I am pretty sure that pg_indent will revert any changes you > > make to the existing ones. > > That it will. The proposed changes to the existing lines are an > exercise in uselessness; and to

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-03 Thread Tom Lane
Robert Haas writes: > On Sun, Jan 3, 2010 at 10:17 PM, Takahiro Itagaki > wrote: >> Robert Haas wrote: >>> - There are needless whitespace changes in the definition of struct >>> Counters.  The changes to the existing four members should be >>> reverted, and the new members should be made to mat

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-03 Thread Robert Haas
On Sun, Jan 3, 2010 at 10:17 PM, Takahiro Itagaki wrote: > Robert Haas wrote: > >> I have reviewed this patch and I think it looks pretty good.  A couple >> of minor nits: >> >> - There are needless whitespace changes in the definition of struct >> Counters.  The changes to the existing four memb

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-03 Thread Takahiro Itagaki
Robert Haas wrote: > I have reviewed this patch and I think it looks pretty good. A couple > of minor nits: > > - There are needless whitespace changes in the definition of struct > Counters. The changes to the existing four members should be > reverted, and the new members should be made to

Re: [HACKERS] Buffer statistics for pg_stat_statements

2009-12-29 Thread Robert Haas
On Tue, Dec 22, 2009 at 3:27 AM, Takahiro Itagaki wrote: > Cedric Villemain wrote: >> Le vendredi 18 decembre 2009 09:44:40, Takahiro Itagaki a ecrit : >> > I'd like to add per-query buffer usage into contrib/pg_stat_statements. > > Here is a patch to add buffer usage columns into pg_stat_stateme

Re: [HACKERS] Buffer statistics for pg_stat_statements

2009-12-22 Thread Cédric Villemain
2009/12/22 Takahiro Itagaki : > > Cedric Villemain wrote: > >> Le vendredi 18 decembre 2009 09:44:40, Takahiro Itagaki a ecrit : >> > I'd like to add per-query buffer usage into contrib/pg_stat_statements. > > Here is a patch to add buffer usage columns into pg_stat_statements. > It also changes i

Re: [HACKERS] Buffer statistics for pg_stat_statements

2009-12-22 Thread Takahiro Itagaki
Cedric Villemain wrote: > Le vendredi 18 decembre 2009 09:44:40, Takahiro Itagaki a ecrit : > > I'd like to add per-query buffer usage into contrib/pg_stat_statements. Here is a patch to add buffer usage columns into pg_stat_statements. It also changes initialzation of the result TupleDesc from

Re: [HACKERS] Buffer statistics for pg_stat_statements

2009-12-18 Thread Cédric Villemain
Le vendredi 18 décembre 2009 09:44:40, Takahiro Itagaki a écrit : > We have infrastructure to count numbers buffer access in 8.5 Alpha 3. > I'd like to add per-query buffer usage into contrib/pg_stat_statements. > > The pg_stat_statements view will have the same contents with > struct BufferUsage.