Re: [HACKERS] A question about code in DefineRelation()

2014-06-24 Thread Heikki Linnakangas
On 04/25/2014 04:39 PM, Hadi Moshayedi wrote: On second thought I noticed that that makes CREATE FOREIGN TABLE include an OID column in newly-created foreign tables wrongly, when the default_with_oids parameter is set to on. Please find attached a patch. Yeah, that's a bug. The interactions

Re: [HACKERS] A question about code in DefineRelation()

2014-05-11 Thread Etsuro Fujita
Hi Hadi, Sorry for the delay. (2014/04/25 22:39), Hadi Moshayedi wrote: On second thought I noticed that that makes CREATE FOREIGN TABLE include an OID column in newly-created foreign tables wrongly, when the default_with_oids parameter is set to on. Please find attached a patch.

Re: [HACKERS] A question about code in DefineRelation()

2014-04-25 Thread Hadi Moshayedi
> > On second thought I noticed that that makes CREATE FOREIGN TABLE include > an OID column in newly-created foreign tables wrongly, when the > default_with_oids parameter is set to on. Please find attached a patch. > > The fix makes sense to me, since in ALTER TABLE SET WITH OIDS we check that t

Re: [HACKERS] A question about code in DefineRelation()

2014-04-22 Thread Etsuro Fujita
(2014/04/04 13:35), Etsuro Fujita wrote: > If I understand correctly, foreign tables cannot have an OID column, but > the following code in DefineRelation() assumes that foreign tables *can* > have that coulum: On second thought I noticed that that makes CREATE FOREIGN TABLE include an OID column