Re: [HACKERS] A question about ExplainOnePlan()

2006-12-13 Thread Tom Lane
"Gurjeet Singh" <[EMAIL PROTECTED]> writes: > On 12/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: >> No; at least not unless you want to duplicate the permission-checking >> machinery inside ExecutorStart. > I had seen the ExecCheckRTPerms() call inside InitPlan(), but didn't know > that we considere

Re: [HACKERS] A question about ExplainOnePlan()

2006-12-13 Thread Gurjeet Singh
On 12/13/06, Tom Lane <[EMAIL PROTECTED]> wrote: "Gurjeet Singh" <[EMAIL PROTECTED]> writes: > Can we avoid calls to Executor{Start|End}() here, or is it necessary to > call them even for non-ANALYZE case? No; at least not unless you want to duplicate the permission-checking machinery insid

Re: [HACKERS] A question about ExplainOnePlan()

2006-12-13 Thread Tom Lane
"Gurjeet Singh" <[EMAIL PROTECTED]> writes: > In ExplainOnePlan(), we are calling ExecutorStart() and ExecutorEnd() > even if we are not doing EXPLAIN ANALYZE. Whereas, ExecutorRun() is called > only if we are ANALYZEing. > Can we avoid calls to Executor{Start|End}() here, or is it necessa