Re: [HACKERS] [WIP] Better partial index-only scans

2014-06-30 Thread Tom Lane
Abhijit Menon-Sen writes: > I don't think it's fair to mark this as returned with feedback without a > more detailed review (I think of returned with feedback as providing a > concrete direction to follow). I've set it back to "needs review". > Does anyone else want to look at this patch? I offe

Re: [HACKERS] [WIP] Better partial index-only scans

2014-06-30 Thread Tom Lane
Joshua Yanovski writes: > Proof of concept initial patch for enabling index only scans for > partial indices even when an attribute is not in the target list, as > long as it is only used in restriction clauses that can be proved by > the index predicate. This also works for index quals, though t

Re: [HACKERS] [WIP] Better partial index-only scans

2014-06-29 Thread Abhijit Menon-Sen
At 2014-06-29 21:55:24 +0300, e...@hasegeli.com wrote: > > I will update the patch as returned with feedback I don't think it's fair to mark this as returned with feedback without a more detailed review (I think of returned with feedback as providing a concrete direction to follow). I've set it ba

Re: [HACKERS] [WIP] Better partial index-only scans

2014-06-29 Thread Emre Hasegeli
Joshua Yanovski : > Proof of concept initial patch for enabling index only scans for > partial indices even when an attribute is not in the target list, as > long as it is only used in restriction clauses that can be proved by > the index predicate. This also works for index quals, though they > s

Re: [HACKERS] [WIP] Better partial index-only scans

2014-03-18 Thread Robert Haas
On Tue, Mar 18, 2014 at 4:18 PM, Joshua Yanovski wrote: >> I'm glad you're looking at this, but we're in the final throws of >> nailing down 9.4 and I don't have anticipate I'll have time to look at >> it in the near future. You should add it here so we don't forget >> about it: >> >> https://com

Re: [HACKERS] [WIP] Better partial index-only scans

2014-03-18 Thread Joshua Yanovski
> I'm glad you're looking at this, but we're in the final throws of > nailing down 9.4 and I don't have anticipate I'll have time to look at > it in the near future. You should add it here so we don't forget > about it: > > https://commitfest.postgresql.org/action/commitfest_view/open Yeah, no wor

Re: [HACKERS] [WIP] Better partial index-only scans

2014-03-18 Thread Robert Haas
On Mon, Mar 17, 2014 at 3:14 AM, Joshua Yanovski wrote: > Here's a SQL script that (1) demonstrates the new index only scan > functionality, and (2) at least on my machine, has a consistently > higher planning time for the version with my change than without it. I'm glad you're looking at this, b

Re: [HACKERS] [WIP] Better partial index-only scans

2014-03-17 Thread Joshua Yanovski
Here's a SQL script that (1) demonstrates the new index only scan functionality, and (2) at least on my machine, has a consistently higher planning time for the version with my change than without it. On Sun, Mar 16, 2014 at 5:08 AM, Joshua Yanovski wrote: > Proof of concept initial patch for ena