Just want to make sure that this wasn't lost in the shuffle somewhere…
Best,
David
On Sep 14, 2008, at 15:42, David E. Wheeler wrote:
On Sep 12, 2008, at 12:49, Alvaro Herrera wrote:
Looks like the IO conversions handle char and "char", so the
attached
patch just updates the regression tes
On Sep 12, 2008, at 12:49, Alvaro Herrera wrote:
Looks like the IO conversions handle char and "char", so the attached
patch just updates the regression test.
There are unresolved conflicts in the patch ...
Bah! Sorry. Let me try that again.
Best,
David
char_tests.patch
Description: Bina
David E. Wheeler escribió:
> On Sep 12, 2008, at 11:35, David E. Wheeler wrote:
>
>> I've got another patch I'm working on adding support for "char" (and
>> tests for char). Just to fill out a gap I saw in the casting coverage.
>> I'm trying to get it done now. With that, AFAIK, citext will work
On Sep 12, 2008, at 11:35, David E. Wheeler wrote:
I've got another patch I'm working on adding support for "char" (and
tests for char). Just to fill out a gap I saw in the casting
coverage. I'm trying to get it done now. With that, AFAIK, citext
will work just like text.
Looks like the I
On Sep 12, 2008, at 11:34, Tom Lane wrote:
CREATE OR REPLACE FUNCTION int8(citext)
RETURNS int8
AS 'SELECT int8( $1::text )'
LANGUAGE SQL IMMUTABLE STRICT;
Yeah, those are all replaced by the CoerceViaIO mechanism
Okay, thanks for the sanity check. The SQL versions are fine for me in
8.3.
On Sep 12, 2008, at 11:31, Tom Lane wrote:
"David E. Wheeler" <[EMAIL PROTECTED]> writes:
Oh, and text_name seems to give me this error:
ERROR: compressed data is corrupt
That's when I have this cast:
CREATE OR REPLACE FUNCTION citext(name)
RETURNS citext
AS 'text_name'
LANGUAGE
"David E. Wheeler" <[EMAIL PROTECTED]> writes:
> Pity. Looks like there were only a few I wasn't using, text_char,
> char_text, text_name, and texttoxml. Do I really need to keep all my
> other casts like these in 8.3?
> CREATE OR REPLACE FUNCTION int8(citext)
> RETURNS int8
> AS 'SELECT int8(
"David E. Wheeler" <[EMAIL PROTECTED]> writes:
> Oh, and text_name seems to give me this error:
> ERROR: compressed data is corrupt
> That's when I have this cast:
> CREATE OR REPLACE FUNCTION citext(name)
> RETURNS citext
> AS 'text_name'
> LANGUAGE internal IMMUTABLE STRICT;
I thin
On Sep 12, 2008, at 11:14, David E. Wheeler wrote:
Pity. Looks like there were only a few I wasn't using, text_char,
char_text, text_name, and texttoxml.
Oh, and text_name seems to give me this error:
ERROR: compressed data is corrupt
That's when I have this cast:
CREATE OR REPLACE FUNC
On Sep 12, 2008, at 11:06, David E. Wheeler wrote:
Er, look into pg_cast and then pg_proc? For instance
select oid::regprocedure, prosrc from pg_proc
where oid in (select castfunc from pg_cast);
That looks like *exactly* what I need. Thanks!
Pity. Looks like there were only a few I wasn't
On Sep 12, 2008, at 10:58, Tom Lane wrote:
1. Did I neglect to include the documentation patch? I've attached it
here. It's necessary because of the addition of the new functions.
Maybe it got left out of the later patch iterations? Anyway,
will take care of it.
Great, thank you.
2. Many
"David E. Wheeler" <[EMAIL PROTECTED]> writes:
> 1. Did I neglect to include the documentation patch? I've attached it
> here. It's necessary because of the addition of the new functions.
Maybe it got left out of the later patch iterations? Anyway,
will take care of it.
> 2. Many thanks for sw
On Sep 5, 2008, at 11:33, David E. Wheeler wrote:
On Sep 5, 2008, at 11:30, Tom Lane wrote:
Thanks for reviewing. I've committed this with your suggestions and
one additional non-cosmetic change: schema-qualify names in the
bodies of the SQL functions so that they are not search_path
depend
On Sep 5, 2008, at 11:30, Tom Lane wrote:
Thanks for reviewing. I've committed this with your suggestions and
one additional non-cosmetic change: schema-qualify names in the
bodies of the SQL functions so that they are not search_path
dependent.
Thanks, I'll check that out.
One thing that
"Ryan Bradetich" <[EMAIL PROTECTED]> writes:
> Here is my review of the Test citext casts written by David Wheeler:
Thanks for reviewing. I've committed this with your suggestions and
one additional non-cosmetic change: schema-qualify names in the
bodies of the SQL functions so that they are not
On Sep 4, 2008, at 21:40, Ryan Bradetich wrote:
Overall I think the patch looks good. After reviewing the patch, I
played with
citext for an hour or so and I did not encounter any bugs or other
surprises.
Thanks for the review, Ryan!
Best,
David
--
Sent via pgsql-hackers mailing list (p
16 matches
Mail list logo
