Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-27 Thread Bruce Momjian
miscinit.c part of patch applied. Thanks. The other part Tom already addressed. --- Lee Kindness wrote: Content-Description: message body text > Tom, happier with the attached patch? > > I'd have to disagree with regar

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > This patch no longer applies cleanly. The call is now: > freeaddrinfo_all(hint.ai_family, addrs); > Would you please submit a new patch, or is it no longer required? That part of the patch is not needed (it is the same as what I changed, excep

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-26 Thread Bruce Momjian
This patch no longer applies cleanly. The call is now: freeaddrinfo_all(hint.ai_family, addrs); Would you please submit a new patch, or is it no longer required? There were two fixed in your patch. Thanks. --

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-23 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Lee Kindness wrote: Content-Description:

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Lee Kindness
Tom Lane writes: > Lee Kindness <[EMAIL PROTECTED]> writes: > > I'd have to disagree with regards to the memory leaks not being worth > > a mention - any such leak can cause problems when the PostgreSQL > > installation is either unattended, long-living andor has very high > > connection level

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Tom Lane
Lee Kindness <[EMAIL PROTECTED]> writes: > I'd have to disagree with regards to the memory leaks not being worth > a mention - any such leak can cause problems when the PostgreSQL > installation is either unattended, long-living andor has very high > connection levels. I don't see how. We are tal

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Lee Kindness
Tom, happier with the attached patch? I'd have to disagree with regards to the memory leaks not being worth a mention - any such leak can cause problems when the PostgreSQL installation is either unattended, long-living andor has very high connection levels. Half a kilobyte on start-up isn't negli

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Tom Lane
Lee Kindness <[EMAIL PROTECTED]> writes: > Guys, attached is a patch to fix two memory leaks on start-up. I do not like the changes to miscinit.c. In the first place, it is not a "memory leak" to do a one-time allocation of state for a proc_exit function. A bigger complaint is that your proposed