Re: [HACKERS] [PATCH] Make gram.y use palloc/pfree for memory management

2008-09-02 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 9/1/08, Marko Kreen <[EMAIL PROTECTED]> wrote: >> First a correction, overriding malloc/free seems dangerous they >> seems to leak out, so correct would be to use YYMALLOC/YYFREE. >> This leaves 1.875 potentially leaking, but danger seems small. > Her

Re: [HACKERS] [PATCH] Make gram.y use palloc/pfree for memory management

2008-09-02 Thread Marko Kreen
On 9/1/08, Marko Kreen <[EMAIL PROTECTED]> wrote: > First a correction, overriding malloc/free seems dangerous they > seems to leak out, so correct would be to use YYMALLOC/YYFREE. > This leaves 1.875 potentially leaking, but danger seems small. Here is the safer patch. As the chance for the le

Re: [HACKERS] [PATCH] Make gram.y use palloc/pfree for memory management

2008-09-01 Thread Marko Kreen
First a correction, overriding malloc/free seems dangerous they seems to leak out, so correct would be to use YYMALLOC/YYFREE. This leaves 1.875 potentially leaking, but danger seems small. On 9/1/08, Tom Lane <[EMAIL PROTECTED]> wrote: > Marko Kreen <[EMAIL PROTECTED]> writes: > > This means gra

Re: [HACKERS] [PATCH] Make gram.y use palloc/pfree for memory management

2008-08-31 Thread Tom Lane
Marko Kreen <[EMAIL PROTECTED]> writes: > This means gram.y can leak memory if error is throws in > the middle of parsing. Please offer some evidence for that claim. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t