Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-03-30 Thread Tom Lane
Andrew Gilligan <[EMAIL PROTECTED]> writes: > I've attached an updated patch (based on 8.3RC2) that adds the ACL > information to \l and the size to \l+ if available. Applied, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-01-28 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Andrew Gilligan wrote: > > On 20 Jan 2008, at 04:34, Tom Lane wrote: > > Andrew Gilligan <[EMAIL PROTECTED]> writes:

Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-01-19 Thread Andrew Gilligan
On 20 Jan 2008, at 04:34, Tom Lane wrote: Andrew Gilligan <[EMAIL PROTECTED]> writes: Showing the size on \l+ probably makes more sense, but I imagine that would require a very different approach due to the permissions changes? I haven't experimented, but perhaps something along the lines o

Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-01-19 Thread Tom Lane
Andrew Gilligan <[EMAIL PROTECTED]> writes: > Showing the size on \l+ probably makes more sense, but I imagine that > would require a very different approach due to the permissions changes? I haven't experimented, but perhaps something along the lines of case when has_database_privilege(c

Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-01-19 Thread Andrew Gilligan
On 20 Jan 2008, at 02:06, Tom Lane wrote: Andrew Gilligan <[EMAIL PROTECTED]> writes: Attached is a rather small change to src/bin/psql/describe.c to show database size and permissions when using the psql \l command. Doesn't this slow down \l by several orders of magnitude? There's also the

Re: [HACKERS] [PATCH] Add size/acl information when listing databases

2008-01-19 Thread Tom Lane
Andrew Gilligan <[EMAIL PROTECTED]> writes: > Attached is a rather small change to src/bin/psql/describe.c to > show database size and permissions when using the psql \l command. Doesn't this slow down \l by several orders of magnitude? There's also the small problem that the query will fail enti