Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Tom Lane
I wrote: > Andrew Dunstan writes: >> Why does pg_test_fsync.c include postgres.h? Shouldn't it use postgres_fe.h? > I had tried that, actually, but it fails because the other include files > test_fsync needs are backend-specific. We may have to refactor those > include files so that the stuff te

Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Tom Lane
Magnus Hagander writes: > I still get: > pg_test_fsync.c > 1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101: 'ops' > : unreferenced local variable > 1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101: > 'writes' : unreferenced local variable > 1>.\contrib\pg_test_fsync\pg

Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Magnus Hagander
On Sat, Jan 22, 2011 at 18:12, Tom Lane wrote: > Andrew Dunstan writes: >> This appears to have broken Solaris, Unixware and MSVC builds. > > BTW, the MSVC problem appears to stem from failure to include libpgport > when linking pg_test_fsync.  I imagine this requires a fix in the MSVC > build sc

Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Tom Lane
Andrew Dunstan writes: > This appears to have broken Solaris, Unixware and MSVC builds. BTW, the MSVC problem appears to stem from failure to include libpgport when linking pg_test_fsync. I imagine this requires a fix in the MSVC build scripts. regards, tom lane -- Sen

Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Tom Lane
Andrew Dunstan writes: > Why does pg_test_fsync.c include postgres.h? Shouldn't it use postgres_fe.h? I had tried that, actually, but it fails because the other include files test_fsync needs are backend-specific. We may have to refactor those include files so that the stuff test_fsync actually

Re: [HACKERS] [COMMITTERS] pgsql: Move test_fsync to /contrib.

2011-01-22 Thread Andrew Dunstan
On 01/21/2011 12:48 PM, Bruce Momjian wrote: Move test_fsync to /contrib. This appears to have broken Solaris, Unixware and MSVC builds. Here's the error on Solaris: gmake[1]: Entering directory `/export/home/dpage/pgbuildfarm/moa/HEAD/pgsql.4167/contrib/pg_test_fsync' cc -Xa -m64 -xarc