Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-16 Thread Bernd Helmle
--On 15. April 2015 15:02:05 -0400 Andrew Dunstan wrote: > We've handled the buildfarm being red for a few days before. People are > usually good about applying fixes fairly quickly. Took me some time to get that due to my mail backlog, but i've done the hotfix for dotterel and forced a run fo

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Alvaro Herrera
Michael Paquier wrote: > On Thu, Apr 16, 2015 at 4:15 AM, Alvaro Herrera > wrote: > > Well, *I* can't write the MSVC patch, but I can't find anyone to > > volunteer some time either :-( I think it's best to have MSVC skip the > > step and have the Makefile-based animals run it. That would give

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Michael Paquier
On Thu, Apr 16, 2015 at 4:15 AM, Alvaro Herrera wrote: > Andrew Dunstan wrote: > >> Yes, we do want support for testmodules. I think that needs to be built into >> src/tools/msvc, probably in vcregress.pl. Once we have that the buildfarm >> changes will be trivial. But if that's not forthcoming qu

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Alvaro Herrera
Andrew Dunstan wrote: > Yes, we do want support for testmodules. I think that needs to be built into > src/tools/msvc, probably in vcregress.pl. Once we have that the buildfarm > changes will be trivial. But if that's not forthcoming quickly I can just > avoid the step on msvc for now. Well, *I*

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Andrew Dunstan
On 04/15/2015 12:23 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: OK, the fix is here: and the new TestUpgrade.pm can be grabbed from here:

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Alvaro Herrera
Andrew Dunstan wrote: > OK, the fix is here: > > and the new TestUpgrade.pm can be grabbed from here: >

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Andrew Dunstan
On 04/15/2015 10:51 AM, Andrew Dunstan wrote: On 04/15/2015 08:31 AM, Michael Paquier wrote: On Wed, Apr 15, 2015 at 7:54 PM, Peter Eisentraut wrote: On 4/14/15 8:32 PM, Peter Eisentraut wrote: Move pg_upgrade from contrib/ to src/bin/ Oh dear. It appears the buildfarm client code needs t

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Andrew Dunstan
On 04/15/2015 08:31 AM, Michael Paquier wrote: On Wed, Apr 15, 2015 at 7:54 PM, Peter Eisentraut wrote: On 4/14/15 8:32 PM, Peter Eisentraut wrote: Move pg_upgrade from contrib/ to src/bin/ Oh dear. It appears the buildfarm client code needs to be updated to support this. How do we do this

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Michael Paquier
On Wed, Apr 15, 2015 at 7:54 PM, Peter Eisentraut wrote: > On 4/14/15 8:32 PM, Peter Eisentraut wrote: >> Move pg_upgrade from contrib/ to src/bin/ > > Oh dear. It appears the buildfarm client code needs to be updated to > support this. How do we do this? (I guess the critters that are still >

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

2015-04-15 Thread Peter Eisentraut
On 4/14/15 8:32 PM, Peter Eisentraut wrote: > Move pg_upgrade from contrib/ to src/bin/ Oh dear. It appears the buildfarm client code needs to be updated to support this. How do we do this? (I guess the critters that are still green are not running this test.) Should I revert this patch while