Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-02-05 Thread Alvaro Herrera
Tom Lane wrote: > Simon Riggs writes: > > On 23 January 2013 17:15, Andres Freund wrote: > >> On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: > >>> Can't we do better than that? > > > "row level locks cannot be applied to the NULLable side of an outer join" > > I think it should read "row-l

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-24 Thread Alvaro Herrera
Alvaro Herrera wrote: > Improve concurrency of foreign key locking I noticed a bug in visibility routines when pg_upgrade is involved: tuples marked FOR UPDATE in the old cluster (i.e. HEAP_XMAX_INVALID not set, HEAP_XMAX_EXCL_LOCK set, HEAP_XMAX_IS_MULTI not set) are invisible (dead) on the new c

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Tom Lane
Simon Riggs writes: > On 23 January 2013 17:15, Andres Freund wrote: >> On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >>> Can't we do better than that? > "row level locks cannot be applied to the NULLable side of an outer join" I think it should read "row-level locks cannot ...", but othe

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andrew Dunstan
On 01/23/2013 12:48 PM, Simon Riggs wrote: On 23 January 2013 17:15, Andres Freund wrote: On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: On 01/23/2013 10:12 AM, Alvaro Herrera wrote: Improve concurrency of foreign key locking This error message change looks rather odd, and has my head

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Alvaro Herrera
Andrew Dunstan wrote: > > On 01/23/2013 10:12 AM, Alvaro Herrera wrote: > >Improve concurrency of foreign key locking > > This error message change looks rather odd, and has my head spinning a bit: > > -errmsg("SELECT FOR UPDATE/SHARE cannot be > applied to the nullable side

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Simon Riggs
On 23 January 2013 17:15, Andres Freund wrote: > On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >> >> On 01/23/2013 10:12 AM, Alvaro Herrera wrote: >> >Improve concurrency of foreign key locking >> >> This error message change looks rather odd, and has my head spinning a bit: >> >> -

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Tom Lane
Andres Freund writes: > On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: >> This error message change looks rather odd, and has my head spinning a bit: >> >> -errmsg("SELECT FOR UPDATE/SHARE cannot be applied to >> the nullable side of an outer join"))); >> +

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andres Freund
On 2013-01-23 11:58:28 -0500, Andrew Dunstan wrote: > > On 01/23/2013 10:12 AM, Alvaro Herrera wrote: > >Improve concurrency of foreign key locking > > This error message change looks rather odd, and has my head spinning a bit: > > -errmsg("SELECT FOR UPDATE/SHARE cannot be a

Re: [HACKERS] [COMMITTERS] pgsql: Improve concurrency of foreign key locking

2013-01-23 Thread Andrew Dunstan
On 01/23/2013 10:12 AM, Alvaro Herrera wrote: Improve concurrency of foreign key locking This error message change looks rather odd, and has my head spinning a bit: -errmsg("SELECT FOR UPDATE/SHARE cannot be applied to the nullable side of an outer join"))); +