Re: [HACKERS] [COMMITTERS] pgsql: Clean up code associated with updating

2006-05-11 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Minor comment: since you removed the - lines from the index_create > > header comment, I think pgindent will mess up the alignment for that > > comment, which probably will not be very nice. Same in > > index_update_stats. Other

Re: [HACKERS] [COMMITTERS] pgsql: Clean up code associated with updating pg_class statistics

2006-05-11 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Minor comment: since you removed the - lines from the index_create > header comment, I think pgindent will mess up the alignment for that > comment, which probably will not be very nice. Same in > index_update_stats. Otherwise, nice work! I will u

Re: [HACKERS] [COMMITTERS] pgsql: Clean up code associated with updating pg_class statistics

2006-05-10 Thread Alvaro Herrera
Tom Lane wrote: > Log Message: > --- > Clean up code associated with updating pg_class statistics columns > (relpages/reltuples). To do this, create formal support in heapam.c for > "overwrite" tuple updates (including xlog replay capability) and use that > instead of the ad-hoc overwrites