On 27.03.2013 15:28, Tom Lane wrote:
Heikki Linnakangas writes:
Alvaro Herrera wrote:
Not happy with misc.c as a filename.
There's a bunch of files called pg_backup_*.c that are also shared
between pg_dump and pg_restore, so perhaps pg_backup_utils.c?
Works for me.
Ok, sold.
- Heikki
Heikki Linnakangas writes:
>> Alvaro Herrera wrote:
>>> Not happy with misc.c as a filename.
> There's a bunch of files called pg_backup_*.c that are also shared
> between pg_dump and pg_restore, so perhaps pg_backup_utils.c?
Works for me. There's inherently not going to be a lot of content
i
On 26.03.2013 22:14, Kevin Grittner wrote:
Alvaro Herrera wrote:
Not happy with misc.c as a filename.
We already have two misc.c files:
src/backend/utils/adt/misc.c
src/interfaces/ecpg/ecpglib/misc.c
I much prefer not to repeat the same filename in different
directories if we can avoid it.
On 2013-03-26 13:14:53 -0700, Kevin Grittner wrote:
> Alvaro Herrera wrote:
>
> > Not happy with misc.c as a filename.
>
> We already have two misc.c files:
>
> src/backend/utils/adt/misc.c
> src/interfaces/ecpg/ecpglib/misc.c
>
> I much prefer not to repeat the same filename in different
> di
Alvaro Herrera wrote:
> Not happy with misc.c as a filename.
We already have two misc.c files:
src/backend/utils/adt/misc.c
src/interfaces/ecpg/ecpglib/misc.c
I much prefer not to repeat the same filename in different
directories if we can avoid it.
> How about pg_dump_utils.c or pg_dump_misc
Heikki Linnakangas wrote:
> This is what I came up with. I created a new file, misc.c (for lack
> of a better name), for things that are shared by pg_dump and
> pg_restore, but not pg_dumpall or other programs. I moved all the
> parallel stuff from dumputils.c to parallel.c, and everything else
>
On 26.03.2013 09:51, Heikki Linnakangas wrote:
On 26.03.2013 02:02, Tom Lane wrote:
Heikki Linnakangas writes:
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangas writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I
On 26.03.2013 02:02, Tom Lane wrote:
Heikki Linnakangas writes:
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangas writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes the buil
Heikki Linnakangas writes:
> On 25.03.2013 15:36, Tom Lane wrote:
>> Heikki Linnakangas writes:
>>> Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
>>> Per warning from -Wmissing-format-attribute.
>> Hm, this is exactly what I removed yesterday, because it makes the build
>> fail outright on old gcc
On 25.03.2013 15:36, Tom Lane wrote:
Heikki Linnakangas writes:
Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes the build
fail outright on old gcc:
gcc -O1 -Wall -Wmissing-prototypes -Wpoi
Heikki Linnakangas writes:
> Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
> Per warning from -Wmissing-format-attribute.
Hm, this is exactly what I removed yesterday, because it makes the build
fail outright on old gcc:
gcc -O1 -Wall -Wmissing-prototypes -Wpointer-arith -Wformat-security
-fno-st
11 matches
Mail list logo
