Re: [HACKERS] Suggested fix for pg_dump

2001-01-12 Thread Philip Warner
At 00:03 13/01/01 +1100, Philip Warner wrote: >At 13:29 7/01/01 -0500, Tom Lane wrote: >>The Hermit Hacker <[EMAIL PROTECTED]> writes: >>> Essentially, worst case scenario, we are going from 'broken->broken' ... >> >>No, I don't think so. The current pg_dump code is only broken if >>you've rename

Re: [HACKERS] Suggested fix for pg_dump

2001-01-12 Thread Philip Warner
At 13:29 7/01/01 -0500, Tom Lane wrote: >The Hermit Hacker <[EMAIL PROTECTED]> writes: >> Essentially, worst case scenario, we are going from 'broken->broken' ... > >No, I don't think so. The current pg_dump code is only broken if >you've renamed a column involved in a foreign-key dependency (if

RE: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread Christopher Kings-Lynne
> Create Table fred(f1 int); > Alter Table fred add constraint primary key(f1); Has support for the above statement (add constraint PK) been added in 7.1? If so, then what other alter table add constraints have been added? CHECK? NOT NULL? Thanks, Chris

Re: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread The Hermit Hacker
On Sun, 7 Jan 2001, Tom Lane wrote: > The Hermit Hacker <[EMAIL PROTECTED]> writes: > > Essentially, worst case scenario, we are going from 'broken->broken' ... > > No, I don't think so. The current pg_dump code is only broken if > you've renamed a column involved in a foreign-key dependency (if

Re: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread Tom Lane
The Hermit Hacker <[EMAIL PROTECTED]> writes: > Essentially, worst case scenario, we are going from 'broken->broken' ... No, I don't think so. The current pg_dump code is only broken if you've renamed a column involved in a foreign-key dependency (if I understood the thread correctly). But Phil

Re: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread The Hermit Hacker
On Sun, 7 Jan 2001, Tom Lane wrote: > The Hermit Hacker <[EMAIL PROTECTED]> writes: > > On Sun, 7 Jan 2001, Philip Warner wrote: > >> Is this OK? Or inappropriate for beta? > > > From Tatsuo's example, it looks critical enough that it should be fixed > > before release, and since its a 'support p

Re: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread Tom Lane
The Hermit Hacker <[EMAIL PROTECTED]> writes: > On Sun, 7 Jan 2001, Philip Warner wrote: >> Is this OK? Or inappropriate for beta? > From Tatsuo's example, it looks critical enough that it should be fixed > before release, and since its a 'support program' issue, not a 'core > server' issue, rami

Re: [HACKERS] Suggested fix for pg_dump

2001-01-07 Thread The Hermit Hacker
On Sun, 7 Jan 2001, Philip Warner wrote: > > The problem with pg_dump and renamed primary key attrs can be fixed by > using the indkey attribute of pg_index to lookup attrs in pg_class - this > is what pg_dump does when it dumps indexes. If I am going to make this > change, I would also like to s