Re: [HACKERS] A couple items on TODO

2001-08-24 Thread Bruce Momjian
> That's good information, now I have a better idea what I am looking for. I am > using Source Navigator (good recommendation I got reading this list). I am > basically just trying to find either variables that can be declared const, or > inconsistancies (as Chris mentions). > > If anyone else

Re: [HACKERS] A couple items on TODO

2001-08-24 Thread Peter Eisentraut
Tom Lane writes: > Yeah, people have started to use 'const' in new code, but the older > stuff doesn't use it, which means that the net effect is probably > more annoyance than help. I'm afraid that if we attack this in an > incremental way, we'll end up with code that may have a lot of const >

RE: [HACKERS] A couple items on TODO

2001-08-23 Thread Christopher Kings-Lynne
> That's good information, now I have a better idea what I am > looking for. I am > using Source Navigator (good recommendation I got reading this > list). I am > basically just trying to find either variables that can be > declared const, or > inconsistancies (as Chris mentions). > > If anyone el

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Jeff Davis
> > > *Add use of 'const' for variables in source tree > > > > I would discuss this item with the hackers list and see exactly what > > people want done with it. > > I have noticed while working on command.c and heap.c that half the > functions pass 'const char *' and the other half pass just 'cha

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > I have noticed while working on command.c and heap.c that half the functions > pass 'const char *' and the other half pass just 'char *'. This is a pain Yeah, people have started to use 'const' in new code, but the older stuff doesn't use i

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Bruce Momjian
> > > As I was browsing TODO, I noticed a couple unassigned items > > that I may be > > > able to help with (I haven't worked with the source before): > > > > > > *Add use of 'const' for variables in source tree > > > > I would discuss this item with the hackers list and see exactly what > > peopl

RE: [HACKERS] A couple items on TODO

2001-08-23 Thread Christopher Kings-Lynne
> > As I was browsing TODO, I noticed a couple unassigned items > that I may be > > able to help with (I haven't worked with the source before): > > > > *Add use of 'const' for variables in source tree > > I would discuss this item with the hackers list and see exactly what > people want done with

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Peter Eisentraut
Tom Lane writes: > AFAIR, elog at NOTICE or DEBUG level isn't really supposed to have any > side-effects. The bigger issue is that you have to be careful about > using it in certain places, mainly during startup or for reporting > communication errors. (send failure -> elog -> tries to send mes

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Bruce Momjian
> AFAIR, elog at NOTICE or DEBUG level isn't really supposed to have any > side-effects. The bigger issue is that you have to be careful about > using it in certain places, mainly during startup or for reporting > communication errors. (send failure -> elog -> tries to send message to > client -

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Jeff Davis writes: >> *Convert remaining fprintf(stderr,...)/perror() to elog() > This isn't quite as easy as a mechanical conversion, mind you, because > elog of course has rather complex side effects besides printing out a > message. AFAIR, elog a

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Peter Eisentraut
Jeff Davis writes: > *Convert remaining fprintf(stderr,...)/perror() to elog() This isn't quite as easy as a mechanical conversion, mind you, because elog of course has rather complex side effects besides printing out a message. What we'd need is some sort of option to print a message of a give

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Bruce Momjian
> As I was browsing TODO, I noticed a couple unassigned items that I may be > able to help with (I haven't worked with the source before): > > *Add use of 'const' for variables in source tree I would discuss this item with the hackers list and see exactly what people want done with it. > *Conv

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread Bruce Momjian
> > I also noticed that this item has been there for a while: > > *Encrpyt passwords in pg_shadow table using MD5 (Bruce, Vince) > > While you are there do you think it's possible to make an mcrypt function? > :) See contrib/pgcrypto. -- Bruce Momjian| http://candle.

Re: [HACKERS] A couple items on TODO

2001-08-23 Thread speedboy
> I also noticed that this item has been there for a while: > *Encrpyt passwords in pg_shadow table using MD5 (Bruce, Vince) While you are there do you think it's possible to make an mcrypt function? :) ---(end of broadcast)--- TIP 5: Have you che