Re: Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-07 Thread Robert Haas
> Applied with really pretty minor revisions --- this was a nice clean > patch. Changes I can recall making: Woo-hoo, my first patch. Thanks for the cleanup. ...Robert > * You missed one or two documentation references to DELETE privilege. > > * You modified the privileges test to create anoth

Re: Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-07 Thread Tom Lane
"Robert Haas" <[EMAIL PROTECTED]> writes: > Updated patch attached, based on comments from Ryan Bradetich and Tom > Lane, and sync'd to latest CVS version. Applied with really pretty minor revisions --- this was a nice clean patch. Changes I can recall making: * You missed one or two documentati

Re: Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-06 Thread Ryan Bradetich
Hello Robert, On Fri, Sep 5, 2008 at 8:13 PM, Robert Haas <[EMAIL PROTECTED]> wrote: > Updated patch attached, based on comments from Ryan Bradetich and Tom > Lane, and sync'd to latest CVS version. Thanks for the update. I am out of town until tomorrow evening. I will re-review this patch when

Re: Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-05 Thread Robert Haas
Updated patch attached, based on comments from Ryan Bradetich and Tom Lane, and sync'd to latest CVS version. ...Robert On Mon, Sep 1, 2008 at 9:33 PM, Tom Lane <[EMAIL PROTECTED]> wrote: > "Ryan Bradetich" <[EMAIL PROTECTED]> writes: >> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <[EMAIL PROTECTED]

Re: Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-01 Thread Tom Lane
"Ryan Bradetich" <[EMAIL PROTECTED]> writes: > On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <[EMAIL PROTECTED]> wrote: >> [ something about "your patch" ] > This is Robert Haas's patch for the September 2008 commit-fest. > I am just offering my review. Sorry about that, I got confused by the reply-to

Fwd: [HACKERS] [Patch Review] TRUNCATE Permission

2008-09-01 Thread Ryan Bradetich
I had intended to send this message to the pgsql-hackers mailing list as well. Thanks, - Ryan -- Forwarded message -- From: Ryan Bradetich <[EMAIL PROTECTED]> Date: Mon, Sep 1, 2008 at 2:20 PM Subject: Re: [HACKERS] [Patch Review] TRUNCATE Permission To: Tom Lane <[EMAIL PROTECTE