Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-04-15 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, Apr 13, 2008 at 6:11 PM, Brendan Jurd wrote: > I've written a patch which implements the same \du behaviour as my > previous patch, but using the new printTable API New versions of this patch, including changes made to the printTable API in

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-04-13 Thread Brendan Jurd
On Tue, Mar 25, 2008 at 2:41 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > This makes me wonder whether print.c could offer something a bit more > > helpful to callers wishing to DIY a table; we could have a > > table-building struct with methods like a

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-24 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I've had a chance to look at this now, and although it certainly does > seem workable, there's a lot of duplication of code that I feel uneasy > about. describeOneTableDetails essentially already duplicates the > table buildling code in printQuery, so I

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-24 Thread Brendan Jurd
On 21/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > We can't just build the output table by hand like > > describeOneTableDetails does? Admittedly it's kludgy, but it's not an > > unprecedented kludge. > > > Oh, I had forgotten the existence of tha

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Brendan Jurd
On 21/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > > We can't just build the output table by hand like > > describeOneTableDetails does? Admittedly it's kludgy, but it's not an > > unprecedented kludge. > > Oh, I had forgotten the existence of tha

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > On 21/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: >> The code is now set up so that it can pass an entire field value >> through gettext(), but if gettext recognizes the strings "foo" and >> "bar" that doesn't mean it will do anything useful with "foo\n

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Brendan Jurd
On 21/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > > The code is now set up so that it can pass an entire field value > through gettext(), but if gettext recognizes the strings "foo" and > "bar" that doesn't mean it will do anything useful with "foo\nbar", > which is what this patch would req

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > gettext localizes the NULL string to the localization header :-( For > example: Oooh, that's even different from the one I thought of :-(. Yeah, we've got a problem here. We could fix that particular issue by changing print.c so that it doesn't attem

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Alvaro Herrera
Brendan Jurd escribió: > I've done up a patch per Tom's idea of combining the binary role > attributes into a single column. Thanks -- this is nice. I even went to apply it, but found a problem: gettext localizes the NULL string to the localization header :-( For example: alvherre=# \du

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-20 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I've done up a patch per Tom's idea of combining the binary role > attributes into a single column. I started to look at committing this and realized that there's a very nasty problem: our current approach to localizing the strings won't work. See this

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-04 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Br

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-04 Thread Bruce Momjian
Alvaro Herrera wrote: > Brendan Jurd escribi?: > > I've done up a patch per Tom's idea of combining the binary role > > attributes into a single column. > > This patch seems to be missing from the queue. Yes because I am still processing email from two weeks ago. I was in Europe for a week. --

Re: [PATCHES] [HACKERS] Show INHERIT in \du

2008-03-04 Thread Alvaro Herrera
Brendan Jurd escribió: > I've done up a patch per Tom's idea of combining the binary role > attributes into a single column. This patch seems to be missing from the queue. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom D