Re: [HACKERS] xpath improvement suggestion

2010-01-28 Thread Robert Haas
On Thu, Jan 28, 2010 at 11:03 PM, Scott Bailey wrote: > Robert Haas wrote: >> On Sun, Jan 17, 2010 at 11:33 AM, Jan Urbański >> wrote: >>> [ detailed review ] >> >> Arie, >> >> Are you planning to submit an updated patch? If so, please do so soon. >> > What is the time limit on this? I've been te

Re: [HACKERS] xpath improvement suggestion

2010-01-28 Thread Scott Bailey
Robert Haas wrote: On Sun, Jan 17, 2010 at 11:33 AM, Jan Urbański wrote: [ detailed review ] Arie, Are you planning to submit an updated patch? If so, please do so soon. Thanks, ...Robert What is the time limit on this? I've been testing Arie's patch and I want to see it get in. I can m

Re: [HACKERS] xpath improvement suggestion

2010-01-27 Thread Robert Haas
On Sun, Jan 17, 2010 at 11:33 AM, Jan Urbański wrote: > [ detailed review ] Arie, Are you planning to submit an updated patch? If so, please do so soon. Thanks, ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.po

Re: [HACKERS] xpath improvement suggestion

2010-01-17 Thread Jan Urbański
Hi, here's a review of the patch: It applies with offsets, but worked fine for me. It works as advertised, and I believe it is a solid step forward from the current situation. As far as the coding goes, the PG_TRY/CATCH in xml_xmlpathobjtoxmltype seems unnecessary in the XPATH_BOOLEAN branch, as

Re: [HACKERS] xpath improvement suggestion

2010-01-12 Thread Scott Bailey
Arie Bikker wrote: Peter Eisentraut wrote: On ons, 2010-01-06 at 23:46 +0100, Arie Bikker wrote: Hope this is the right attachement type (I'm new at this) BTW. here a some nice examples: - Get the number of attributes of the first childnode: select ( xpath('count(@*)',(xpath('*[1]','g="j"/>

Re: [HACKERS] xpath improvement suggestion

2010-01-11 Thread Arie Bikker
Peter Eisentraut wrote: On ons, 2010-01-06 at 23:46 +0100, Arie Bikker wrote: Hope this is the right attachement type (I'm new at this) BTW. here a some nice examples: - Get the number of attributes of the first childnode: select ( xpath('count(@*)',(xpath('*[1]','g="j"/>'))[1]))[1]; - an

Re: [HACKERS] xpath improvement suggestion

2010-01-10 Thread Peter Eisentraut
On ons, 2010-01-06 at 23:46 +0100, Arie Bikker wrote: > Hope this is the right attachement type (I'm new at this) > BTW. here a some nice examples: > > - Get the number of attributes of the first childnode: > > select ( xpath('count(@*)',(xpath('*[1]',' g="j"/>'))[1]))[1]; > > - an alternative f

Re: [HACKERS] xpath improvement suggestion

2010-01-06 Thread Scott Bailey
Arie Bikker wrote: Sorry for the previous NUUUB post, didn't now the mailing list doesn't support html ;( Robert Haas wrote: On Tue, Jan 5, 2010 at 6:09 PM, Arie Bikker wrote: Hi all, Well I had to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()',''

Re: [HACKERS] xpath improvement suggestion

2010-01-06 Thread Arie Bikker
Sorry for the previous NUUUB post, didn't now the mailing list doesn't support html ;( Robert Haas wrote: On Tue, Jan 5, 2010 at 6:09 PM, Arie Bikker wrote: Hi all, Well I had to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()',''); doesn't give the e

Re: [HACKERS] xpath improvement suggestion

2010-01-06 Thread Arie Bikker
Robert Haas wrote: On Tue, Jan 5, 2010 at 6:09 PM, Arie Bikker wrote: Hi all, Well I had  to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()',''); doesn't give the expected result. Kept getting an empty array:  xpath - {} instead

Re: [HACKERS] xpath improvement suggestion

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 6:09 PM, Arie Bikker wrote: > Hi all, > > Well I had  to burn some midnight oil trying to figure out why a construct > like > SELECT xpath('name()',''); > doesn't give the expected result. Kept getting an empty array: >  xpath > - > {} > instead of the expected "

Re: [HACKERS] xpath improvement suggestion

2010-01-05 Thread Scott Bailey
Arie Bikker wrote: Hi all, Well I had to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()',''); doesn't give the expected result. Kept getting an empty array: xpath - {} instead of the expected "{a}" BugID 4294 and the TODO item "better handl

[HACKERS] xpath improvement suggestion

2010-01-05 Thread Arie Bikker
Hi all, Well I had to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()',''); doesn't give the expected result. Kept getting an empty array: xpath - {} instead of the expected "{a}" BugID 4294 and the TODO item "better handling of XPath data ty