Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Peter Eisentraut
On 3/4/15 5:00 PM, Robert Haas wrote: >> You can always test the server version number, and you'll have to for >> the next major release anyway. > > That's not really the problem, of course. The problem is you upgrade > and your app unexpectedly breaks. The complexity of fixing that once > it's

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Robert Haas
On Wed, Mar 4, 2015 at 4:11 PM, Peter Eisentraut wrote: > That said, if I understand your test case correctly, this would > basically be an argument against any semantic corrections in stable > releases, since user code could expect to continue to work with the > previous incorrect value. > > You

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Peter Eisentraut
On 3/4/15 12:20 PM, Marko Tiikkaja wrote: > On 3/4/15 6:19 PM, I wrote: >> On 3/4/15 5:26 PM, Tom Lane wrote: >>> It was considered to be a bug fix; more, given the few complaints about >>> the clearly-broken old behavior, we thought it was a fix that would >>> affect >>> few people, and them posit

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Marko Tiikkaja
On 3/4/15 6:19 PM, I wrote: On 3/4/15 5:26 PM, Tom Lane wrote: It was considered to be a bug fix; more, given the few complaints about the clearly-broken old behavior, we thought it was a fix that would affect few people, and them positively. Yeah, but these things usually go the other way. "

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Marko Tiikkaja
On 3/4/15 5:26 PM, Tom Lane wrote: Robert Haas writes: On Thu, Feb 19, 2015 at 5:53 AM, Marko Tiikkaja wrote: I'm not sure how changing behavior like this in a minor release was considered acceptable. I'm guessing that the fact that it changes behavior in cases like this wasn't recognized,

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Mike Rylander
On Thu, Feb 19, 2015 at 5:53 AM, Marko Tiikkaja wrote: > Hi, > > Commit 79af9a1d2668c9edc8171f03c39e7fed571eeb98 changed xpath handling > with regard to namespaces, and it seems to be fixing an actual issue. > However, it was also backpatched to all branches despite it breaking for > example code

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Tom Lane
Robert Haas writes: > On Thu, Feb 19, 2015 at 5:53 AM, Marko Tiikkaja wrote: >> I'm not sure how changing behavior like this in a minor release was >> considered acceptable. > I'm guessing that the fact that it changes behavior in cases like this > wasn't recognized, but I suppose Peter will hav

Re: [HACKERS] xpath changes in the recent back branches

2015-03-04 Thread Robert Haas
On Thu, Feb 19, 2015 at 5:53 AM, Marko Tiikkaja wrote: > Commit 79af9a1d2668c9edc8171f03c39e7fed571eeb98 changed xpath handling with > regard to namespaces, and it seems to be fixing an actual issue. However, it > was also backpatched to all branches despite it breaking for example code > like thi

[HACKERS] xpath changes in the recent back branches

2015-02-19 Thread Marko Tiikkaja
Hi, Commit 79af9a1d2668c9edc8171f03c39e7fed571eeb98 changed xpath handling with regard to namespaces, and it seems to be fixing an actual issue. However, it was also backpatched to all branches despite it breaking for example code like this: do $$ declare _x xml; begin _x := (xpath('/x:Foo/x