Re: [HACKERS] writable FDWs / update targets confusion

2013-12-06 Thread Tom Lane
Tomas Vondra writes: > I think that we should make the documentation more explicit about this > limitation, because the current wording in fdw-callbacks documentation > seems to suggest it's possible to add such hidden columns. At least > that's how I read it before running into this. You can add

Re: [HACKERS] writable FDWs / update targets confusion

2013-12-06 Thread Tomas Vondra
On 18.11.2013 09:28, Albe Laurenz wrote: > Tom Lane wrote: >>> Tom, could you show us a rope if there is one? >> >> What is it you actually need to fetch? >> >> IIRC, the idea was that most FDWs would do the equivalent of fetching the >> primary-key columns to use in an update. If that's what you

Re: [HACKERS] writable FDWs / update targets confusion

2013-11-18 Thread Albe Laurenz
Tom Lane wrote: >> Tom, could you show us a rope if there is one? > > What is it you actually need to fetch? > > IIRC, the idea was that most FDWs would do the equivalent of fetching the > primary-key columns to use in an update. If that's what you need, then > AddForeignUpdateTargets should ide

Re: [HACKERS] writable FDWs / update targets confusion

2013-11-15 Thread Tom Lane
Albe Laurenz writes: > Tom, could you show us a rope if there is one? What is it you actually need to fetch? IIRC, the idea was that most FDWs would do the equivalent of fetching the primary-key columns to use in an update. If that's what you need, then AddForeignUpdateTargets should identify t

Re: [HACKERS] writable FDWs / update targets confusion

2013-11-15 Thread Albe Laurenz
Tomas Vondra wrote: > I'm working on adding write support to one of my FDWs. Adding INSERT went > pretty fine, but when adding DELETE/UPDATE I got really confused about how > the update targets are supposed to work. > > My understanding of how it's supposed to work is this: > > (1) AddForeignUpd

[HACKERS] writable FDWs / update targets confusion

2013-11-12 Thread Tomas Vondra
Hi, I'm working on adding write support to one of my FDWs. Adding INSERT went pretty fine, but when adding DELETE/UPDATE I got really confused about how the update targets are supposed to work. My understanding of how it's supposed to work is this: (1) AddForeignUpdateTargets adds columns that