On Sun, Jan 10, 2010 at 13:44, Magnus Hagander wrote:
> On Sun, Jan 10, 2010 at 13:33, James Mansion
> wrote:
>> Tom Lane wrote:
>>>
>>> There's another copy of ListenSocket[] in the BackendParameters struct.
>>> I also wonder about postmaster.c's habit of using -1 for empty slots
>>> in ListenSo
On Sun, Jan 10, 2010 at 13:33, James Mansion
wrote:
> Tom Lane wrote:
>>
>> There's another copy of ListenSocket[] in the BackendParameters struct.
>> I also wonder about postmaster.c's habit of using -1 for empty slots
>> in ListenSocket ... how safe is that for Win64?
>>
>
> On Windows, it shoul
Tom Lane wrote:
There's another copy of ListenSocket[] in the BackendParameters struct.
I also wonder about postmaster.c's habit of using -1 for empty slots
in ListenSocket ... how safe is that for Win64?
On Windows, it should be INVALID_SOCKET.
James
--
Sent via pgsql-hackers mailing list
Magnus Hagander writes:
> On Wed, Jan 6, 2010 at 22:42, Tom Lane wrote:
>> Can't think of one, but you could try grepping for the socket-related
>> syscalls to see what variables are referenced there.
> Found two more by going over it again that way.
> Unless there are objections, I will apply
On Wed, Jan 6, 2010 at 22:42, Tom Lane wrote:
> Magnus Hagander writes:
>> Is there a good trick to find out if you've touched every place you
>> need to, because I'm very unsure I have. I don't even get a warning in
>> more than those two places, but there ought to be some way to trick
>> the sy
Magnus Hagander writes:
> On Wed, Jan 6, 2010 at 23:17, Tom Lane wrote:
>> BTW, I trust the non-windows case should be "int".
> Haha, yeah, that was my attempt at producing a warning. Which didn't work :-)
Hmm ... "char *" would provoke warnings, but only in the places that
were using the new d
On Wed, Jan 6, 2010 at 23:17, Tom Lane wrote:
> Magnus Hagander writes:
>> + /* socket has a different definition on WIN32 */
>> + #ifndef WIN32
>> + typedef char pgsocket;
>> + #else
>> + typedef SOCKET pgsocket;
>> + #endif
>
> BTW, I trust the non-windows case should be "int".
Haha, yeah, tha
Magnus Hagander writes:
> + /* socket has a different definition on WIN32 */
> + #ifndef WIN32
> + typedef char pgsocket;
> + #else
> + typedef SOCKET pgsocket;
> + #endif
BTW, I trust the non-windows case should be "int".
regards, tom lane
--
Sent via pgsql-hackers mai
Magnus Hagander writes:
> Is there a good trick to find out if you've touched every place you
> need to, because I'm very unsure I have. I don't even get a warning in
> more than those two places, but there ought to be some way to trick
> the system to tell me?
Can't think of one, but you could t
On Fri, Jan 1, 2010 at 20:55, Magnus Hagander wrote:
> On Fri, Jan 1, 2010 at 20:41, Tom Lane wrote:
>> Magnus Hagander writes:
>>> The win64 port has showed that we have two sockets declared
>>> incorrectly. They are supposed to be declared as SOCKET on win32, but
>>> they are declared as int.
On Sun, Jan 3, 2010 at 17:45, Peter Eisentraut wrote:
> On fre, 2010-01-01 at 20:25 +0100, Magnus Hagander wrote:
>> The win64 port has showed that we have two sockets declared
>> incorrectly. They are supposed to be declared as SOCKET on win32, but
>> they are declared as int. See attached patch.
On fre, 2010-01-01 at 20:25 +0100, Magnus Hagander wrote:
> The win64 port has showed that we have two sockets declared
> incorrectly. They are supposed to be declared as SOCKET on win32, but
> they are declared as int. See attached patch.
>
> Given that SOCKET is actually defined as int on win32
On Fri, Jan 1, 2010 at 20:41, Tom Lane wrote:
> Magnus Hagander writes:
>> The win64 port has showed that we have two sockets declared
>> incorrectly. They are supposed to be declared as SOCKET on win32, but
>> they are declared as int. See attached patch.
>
>> Given that SOCKET is actually defin
Magnus Hagander writes:
> The win64 port has showed that we have two sockets declared
> incorrectly. They are supposed to be declared as SOCKET on win32, but
> they are declared as int. See attached patch.
> Given that SOCKET is actually defined as int on win32 (no warnings or
> anything there, j
The win64 port has showed that we have two sockets declared
incorrectly. They are supposed to be declared as SOCKET on win32, but
they are declared as int. See attached patch.
Given that SOCKET is actually defined as int on win32 (no warnings or
anything there, just on win64), I'm inclined to appl
15 matches
Mail list logo
