Robert Haas wrote:
> On Thu, Nov 3, 2011 at 3:45 PM, Kevin Grittner
> wrote:
> > "Kevin Grittner" wrote:
> >> Untested patch attached for purposes of discussion.
> >
> > I got in a little testing on it -- not only does this patch
> > eliminate the compile-time warning, but if you try to run pg_up
On Thu, Nov 3, 2011 at 3:45 PM, Kevin Grittner
wrote:
> "Kevin Grittner" wrote:
>> Untested patch attached for purposes of discussion.
>
> I got in a little testing on it -- not only does this patch
> eliminate the compile-time warning, but if you try to run pg_upgrade
> when another session has
"Kevin Grittner" wrote:
> Untested patch attached for purposes of discussion.
I got in a little testing on it -- not only does this patch
eliminate the compile-time warning, but if you try to run pg_upgrade
when another session has removed your current working directory, you
get a reasonable m
I just noticed a warning in pg_upgrade:
option.c: In function *parseCommandLine*:
option.c:96:8: warning: ignoring return value of *getcwd*,
declared
with attribute warn_unused_result
It looks like it might be worth testing the return value here for
NULL, which would indicate an error accessing
