Re: [HACKERS] warning in code while building on windows

2013-08-18 Thread Amit Kapila
On Mon, Aug 19, 2013 at 9:33 AM, Tom Lane wrote: > Andrew Dunstan writes: >>> Amit Kapila escribió: 1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: 'isnull' : unreferenced local variable > >> The macro is pretty gcc-specific, isn't it? > > If that's the problem, why i

Re: [HACKERS] warning in code while building on windows

2013-08-18 Thread Tom Lane
Andrew Dunstan writes: >> Amit Kapila escribió: >>> 1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: >>> 'isnull' : unreferenced local variable > The macro is pretty gcc-specific, isn't it? If that's the problem, why isn't Amit seeing a boatload of similar warnings elsewhere?

Re: [HACKERS] warning in code while building on windows

2013-08-18 Thread Alvaro Herrera
Andrew Dunstan escribió: > > On 08/18/2013 05:08 PM, Alvaro Herrera wrote: > >Amit Kapila escribió: > >>1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: > >>'isnull' : unreferenced local variable > >> > >>It seems this variable is used only under macro USE_ASSERT_CHECKING, > >>so

Re: [HACKERS] warning in code while building on windows

2013-08-18 Thread Andrew Dunstan
On 08/18/2013 05:08 PM, Alvaro Herrera wrote: Amit Kapila escribió: 1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: 'isnull' : unreferenced local variable It seems this variable is used only under macro USE_ASSERT_CHECKING, so it is better to declare under this macro only.

Re: [HACKERS] warning in code while building on windows

2013-08-18 Thread Alvaro Herrera
Amit Kapila escribió: > 1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: > 'isnull' : unreferenced local variable > > It seems this variable is used only under macro USE_ASSERT_CHECKING, > so it is better to declare under this macro only. We have a macro for this, PG_USED_FOR_AS

[HACKERS] warning in code while building on windows

2013-08-17 Thread Amit Kapila
1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101: 'isnull' : unreferenced local variable It seems this variable is used only under macro USE_ASSERT_CHECKING, so it is better to declare under this macro only. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -