Re: [HACKERS] walreceiver fallback_application_name

2011-01-17 Thread Dimitri Fontaine
Fujii Masao writes: >>>  http://www.postgresql.org/docs/9.0/interactive/runtime-config-wal.html#GUC-MAX-WAL-SENDERS > > +1 though I could not find the mention to "walreceiver" in the doc. True, we already use "wal sender", I should have said "similar phrasing". Regards, -- Dimitri Fontaine http

Re: [HACKERS] walreceiver fallback_application_name

2011-01-17 Thread Magnus Hagander
On Mon, Jan 17, 2011 at 10:57, Magnus Hagander wrote: > On Mon, Jan 17, 2011 at 04:05, Fujii Masao wrote: >>> diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c >>> b/src/backend/replication/libpqwalreceiver/libpqwalreceiv >>> index c052df2..962ee04 100644 >>> --- a/src/back

Re: [HACKERS] walreceiver fallback_application_name

2011-01-17 Thread Magnus Hagander
On Mon, Jan 17, 2011 at 04:05, Fujii Masao wrote: > On Mon, Jan 17, 2011 at 11:16 AM, Robert Haas wrote: >> On Sun, Jan 16, 2011 at 3:53 PM, Dimitri Fontaine >> wrote: >>> Magnus Hagander writes: Is "walreceiver" something that "the average DBA" is going to realize what it is? Perhaps

Re: [HACKERS] walreceiver fallback_application_name

2011-01-17 Thread Bernd Helmle
--On 16. Januar 2011 21:53:47 +0100 Dimitri Fontaine wrote: Is "walreceiver" something that "the average DBA" is going to realize what it is? Perhaps go for something like "replication slave"? I think walreceiver is very good here, and the user is already confronted to such phrasing. ht

Re: [HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Fujii Masao
On Mon, Jan 17, 2011 at 11:16 AM, Robert Haas wrote: > On Sun, Jan 16, 2011 at 3:53 PM, Dimitri Fontaine > wrote: >> Magnus Hagander writes: >>> Is "walreceiver" something that "the average DBA" is going to realize >>> what it is? Perhaps go for something like "replication slave"? >> >> I think

Re: [HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Robert Haas
On Sun, Jan 16, 2011 at 3:53 PM, Dimitri Fontaine wrote: > Magnus Hagander writes: >> Is "walreceiver" something that "the average DBA" is going to realize >> what it is? Perhaps go for something like "replication slave"? > > I think walreceiver is very good here, and the user is already > confro

Re: [HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Dimitri Fontaine
Magnus Hagander writes: > Is "walreceiver" something that "the average DBA" is going to realize > what it is? Perhaps go for something like "replication slave"? I think walreceiver is very good here, and the user is already confronted to such phrasing. http://www.postgresql.org/docs/9.0/inter

Re: [HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Magnus Hagander
On Sun, Jan 16, 2011 at 17:29, Tom Lane wrote: > Magnus Hagander writes: >> Since we now show the application name in pg_stat_replication, I think >> it would make sense to have the walreceiver set >> fallback_application_name on the connection string, like so: > > Seems reasonable, but "postgres

Re: [HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Tom Lane
Magnus Hagander writes: > Since we now show the application name in pg_stat_replication, I think > it would make sense to have the walreceiver set > fallback_application_name on the connection string, like so: Seems reasonable, but "postgres" is a mighty poor choice of name for that, no? I don't

[HACKERS] walreceiver fallback_application_name

2011-01-16 Thread Magnus Hagander
Since we now show the application name in pg_stat_replication, I think it would make sense to have the walreceiver set fallback_application_name on the connection string, like so: diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/li