Re: [HACKERS] useless assignment pointer argument

2015-05-28 Thread Tom Lane
Andres Freund writes: > On 2015-05-28 20:14:33 +, Gaetano Mendola wrote: >> src/backend/commands/explain.c:1692 >> src/backend/commands/explain.c:1874 >> src/backend/commands/explain.c:1986 >> >> there is the following assignment: >> >> ancestors = list_delete_first(ancestors); >> >> but it

Re: [HACKERS] useless assignment pointer argument

2015-05-28 Thread Gaetano Mendola
If the compiler is good the assignment is elided indeed, that's not what I meant to point out. On Thu, 28 May 2015 at 22:17 Andres Freund wrote: > On 2015-05-28 20:14:33 +, Gaetano Mendola wrote: > > src/backend/commands/explain.c:1692 > > src/backend/commands/explain.c:1874 > > src/backend/

Re: [HACKERS] useless assignment pointer argument

2015-05-28 Thread Andres Freund
On 2015-05-28 20:14:33 +, Gaetano Mendola wrote: > src/backend/commands/explain.c:1692 > src/backend/commands/explain.c:1874 > src/backend/commands/explain.c:1986 > > there is the following assignment: > >ancestors = list_delete_first(ancestors); > > but it has no effect at all being tha

[HACKERS] useless assignment pointer argument

2015-05-28 Thread Gaetano Mendola
Hi, in the following spots: src/backend/commands/explain.c:1692 src/backend/commands/explain.c:1874 src/backend/commands/explain.c:1986 there is the following assignment: ancestors = list_delete_first(ancestors); but it has no effect at all being that a function parameter and not used anymor