On Fri, Aug 4, 2017 at 3:01 AM, Robert Haas wrote:
> On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote:
>> So we can remove scanned_tuples from LVRelStats struct and change the
>> variable name num_tuples to scanned_tuples. Attached updated patch.
>
> On second thought, I think we should just
On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote:
> So we can remove scanned_tuples from LVRelStats struct and change the
> variable name num_tuples to scanned_tuples. Attached updated patch.
On second thought, I think we should just leave this alone.
scanned_tuples is closely tied to tupcou
On Wed, Aug 2, 2017 at 11:40 PM, Robert Haas wrote:
> On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada
> wrote:
>> scanned_tuples variable in LVRelStats is introduced by commit b4b6923e
>> but it seems to me that it's actually not used. We store num_tuples
>> into vacrelstats->scanned_tuples aft
On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada wrote:
> scanned_tuples variable in LVRelStats is introduced by commit b4b6923e
> but it seems to me that it's actually not used. We store num_tuples
> into vacrelstats->scanned_tuples after scanned all blocks, and the
> comment mentioned that savin
Hi,
scanned_tuples variable in LVRelStats is introduced by commit b4b6923e
but it seems to me that it's actually not used. We store num_tuples
into vacrelstats->scanned_tuples after scanned all blocks, and the
comment mentioned that saving it in order to use later but we actually
use num_tuples in
Thank you.
At Wed, 26 Oct 2016 10:20:28 -0400, Tom Lane wrote in
<17387.1477491...@sss.pgh.pa.us>
> Kyotaro HORIGUCHI writes:
> > Hello, compiler complains about unused variable during build
> > postgres_fdw without assertions (!--enable-cassert).
> > The attched patch removes it and moves into
Hi,
At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat
wrote in
> On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
> wrote:
> Thanks for the patch and sorry for missing this in the review. I
>
> The patch applies but seems to have a trailing white space.
Oops. My 'git commit' has a hook t
Kyotaro HORIGUCHI writes:
> Hello, compiler complains about unused variable during build
> postgres_fdw without assertions (!--enable-cassert).
> The attched patch removes it and moves into the assertion below it.
Pushed, thanks.
regards, tom lane
--
Sent via pgsql-hac
On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
wrote:
> Hello, compiler complains about unused variable during build
> postgres_fdw without assertions (!--enable-cassert).
>
> deparse.c: In function ‘deparseFromExpr’:
> deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variabl
Hello, compiler complains about unused variable during build
postgres_fdw without assertions (!--enable-cassert).
deparse.c: In function ‘deparseFromExpr’:
deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable]
RelOptInfo *foreignrel = context->foreignrel;
^~~
Petr Jelinek writes:
> my compiler complains about unused variable nblkno in _hash_splitbucket
> in no-assert build. It looks like relic of commit ed9cc2b5d which
> removed the only use of that variable besides the Assert.
Fixed, thanks!
regards, tom lane
--
Sent via
Hi,
my compiler complains about unused variable nblkno in _hash_splitbucket
in no-assert build. It looks like relic of commit ed9cc2b5d which
removed the only use of that variable besides the Assert.
Looking at the code:
nblkno = start_nblkno;
Assert(nblkno == BufferGetBlockNu
Fixed in CVS.
---
Gaetano Mendola wrote:
> Hi all,
>
> I'm compiling the last postgres CVS version and I get:
>
> vacuum.c: In function `repair_frag':
> vacuum.c:1528: warning: unused variable `myXID'
>
>
>
> Regards
>
Hi all,
I'm compiling the last postgres CVS version and I get:
vacuum.c: In function `repair_frag':
vacuum.c:1528: warning: unused variable `myXID'
Regards
Gaetano Mendola
---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EM
OK, it turns out myXID is only used by Assert tests, and most developers
compile with Asserts. I have fixed this by defining the variable only
when asserts are enabled.
Patch attached and applied.
---
Gaetano Mendola wrote
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi all,
I'm compiling the last postgres CVS version and I get:
vacuum.c: In function `repair_frag':
vacuum.c:1528: warning: unused variable `myXID'
Regards
Gaetano Mendola
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (MingW32)
Comment: Using Gn
16 matches
Mail list logo
