On fre, 2009-11-27 at 10:22 -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > + printfPQExpBuffer(errorMessage,
> > + libpq_gettext("ERROR: service
> > \"%s\" not found\n"), service);
>
> Please make the message consistent with the rest o
Peter Eisentraut writes:
> + printfPQExpBuffer(errorMessage,
> + libpq_gettext("ERROR: service
> \"%s\" not found\n"), service);
Please make the message consistent with the rest of libpq. AFAICS none
of the other messages in that file us
On tor, 2009-11-26 at 10:57 +0200, Peter Eisentraut wrote:
> When using the "service" parameter in a libpq connection (e.g., psql
> service=foo), and the service name is not defined in pg_service.conf,
> then the setting is silently ignored and the connection proceeds with
> whatever other settings
Peter Eisentraut wrote:
> When using the "service" parameter in a libpq connection (e.g., psql
> service=foo), and the service name is not defined in pg_service.conf,
> then the setting is silently ignored and the connection proceeds with
> whatever other settings and defaults apply. That does not
When using the "service" parameter in a libpq connection (e.g., psql
service=foo), and the service name is not defined in pg_service.conf,
then the setting is silently ignored and the connection proceeds with
whatever other settings and defaults apply. That does not look very
robust. Shouldn't th
